Bug 992940 - Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5
Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jitka Plesnikova
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 991773
  Show dependency treegraph
 
Reported: 2013-08-05 05:04 EDT by Petr Pisar
Modified: 2013-08-05 09:24 EDT (History)
3 users (show)

See Also:
Fixed In Version: perl-Syntax-Keyword-Junction-0.003004-1.fc20
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-08-05 09:24:52 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jplesnik: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Petr Pisar 2013-08-05 05:04:58 EDT
Spec URL: http://ppisar.fedorapeople.org/perl-Syntax-Keyword-Junction/perl-Syntax-Keyword-Junction.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Syntax-Keyword-Junction/perl-Syntax-Keyword-Junction-0.003004-1.fc20.src.rpm
Description:
This is a lightweight module which provides 'Junction' operators, the most
commonly used being any and all. Inspired by the Perl6 design docs,
<http://dev.perl.org/perl6/doc/design/exe/E06.html>.

Fedora Account System Username: ppisar
Comment 1 Paul Howarth 2013-08-05 08:33:27 EDT
rpmlint output:

perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US http -> HTTP
perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US dev -> deb, derv, div
perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US exe -> ex, exes, exec
perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US http -> HTTP
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US dev -> deb, derv, div
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US exe -> ex, exes, exec
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

provides:

perl(Syntax::Feature::Junction) = 0.003004
perl(Syntax::Keyword::Junction) = 0.003004
perl(Syntax::Keyword::Junction::All) = 0.003004
perl(Syntax::Keyword::Junction::Any) = 0.003004
perl(Syntax::Keyword::Junction::Base) = 0.003004
perl(Syntax::Keyword::Junction::None) = 0.003004
perl(Syntax::Keyword::Junction::One) = 0.003004
perl-Syntax-Keyword-Junction = 0.003004-1.fc20

requires:

perl(:MODULE_COMPAT_5.18.0)
perl(Sub::Exporter::Progressive) >= 0.001006
perl(Syntax::Keyword::Junction)
perl(Syntax::Keyword::Junction::All)
perl(Syntax::Keyword::Junction::Any)
perl(Syntax::Keyword::Junction::Base)
perl(Syntax::Keyword::Junction::None)
perl(Syntax::Keyword::Junction::One)
perl(base)
perl(if)
perl(overload)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

review checklist:

- rpmlint ok; the html and http acronyms could be capitalized but it's no blocker
- package and spec naming OK
- package meets guidelines
- license is (GPL+ or Artistic), same as upstream and OK for Fedora
- license text is bundled and packaged
- spec file written in English and is legible
- source matches upstream
- package builds fine in Rawhide
- build dependencies fully specified
- no locale data to worry about
- no libraries to worry about
- no bundled code present
- package is not intended to be relocatable
- directory ownership OK
- no duplicate files
- permissions OK
- macro usage is consistent
- package is code, not content
- no large docs
- docs don't affect runtime
- no devel bits to worry about
- not a GUI app, no desktop file needed
- filenames are all ASCII

Nits:

Should BR: at least version 0.88 of Test::More due to use of done_testing in t/syntax.t

APPROVED.
Comment 2 Jitka Plesnikova 2013-08-05 08:54:37 EDT
rpmlint ok
License ok
Build-requires ok
Binary requires ok
Binary provides ok
Package meets guidelines
Source matches upstream
Source0 is a working URL
Package builds fine
%check is present and all tests pass

Package is good.
Comment 3 Petr Pisar 2013-08-05 08:56:21 EDT
> Should BR: at least version 0.88 of Test::More due to use of done_testing in t/syntax.t

Indeed. I asked upstream to declare the version too <https://github.com/frioux/Syntax-Keyword-Junction/issues/6>.
Comment 4 Petr Pisar 2013-08-05 08:57:32 EDT
New Package SCM Request
=======================
Package Name: perl-Syntax-Keyword-Junction
Short Description: Perl6 style Junction operators in Perl5
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2013-08-05 09:04:24 EDT
Git done (by process-git-requests).
Comment 6 Petr Pisar 2013-08-05 09:24:52 EDT
Thank you for the reviews and the repository.

Note You need to log in before you can comment on or make changes to this bug.