Bug 994552 (dolphin-plugins) - Review Request: dolphin-plugins - Dolphin plugins for revision control systems
Summary: Review Request: dolphin-plugins - Dolphin plugins for revision control systems
Keywords:
Status: CLOSED RAWHIDE
Alias: dolphin-plugins
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2013-08-07 13:42 UTC by Jan Grulich
Modified: 2013-08-14 13:38 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-08-14 13:38:07 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jan Grulich 2013-08-07 13:42:46 UTC
Spec URL: http://jgrulich.fedorapeople.org/dolphin-plugins.spec
SRPM URL: http://jgrulich.fedorapeople.org/dolphin-plugins-4.10.97-1.fc19.src.rpm
Description: Plugins for the Dolphin file manager integrating the following revision control
systems:
* Git
* Subversion (SVN)
* Bazaar (Bzr)
* Mercurial (Hg)
Fedora Account System Username: jgrulich

Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5789786

This package was previously part of kdesdk. Now it's distributed separately in KDE 4.11.

Comment 1 Rex Dieter 2013-08-07 13:53:09 UTC
Need to add
Obsoletes: kdesdk-dolphin-plugins < 7:4.10.80
too, for upgrade path.

Comment 2 Rex Dieter 2013-08-07 13:55:37 UTC
Just checked, prior kdesdk pkg had no epoch, so need to leave out the 7: parts

Comment 4 Rex Dieter 2013-08-13 22:59:41 UTC
1.  better url,
https://projects.kde.org/projects/kde/kdesdk/dolphin-plugins

2.  SHOULD drop unused
BuildRequires:  desktop-file-utils

naming: ok

licensing: ok

macros: ok

scriptlets: n/a

3.  dependencies: hrm, since these are dolphin plugins, probably ought to add a dependency on it, something like:
Requires: dolphin%{?_kde4_version: >= %{_kde4_version}}
(dolphin is currently a virtual provides in kde-baseapps)

these items are largely cosmetic, and can be fixed post-review.


APPROVED.

Comment 5 Jan Grulich 2013-08-14 05:22:15 UTC
New Package SCM Request
=======================
Package Name: dolphin-plugins
Short Description: Dolphin plugins for revision control systems
Owners: than rdieter kkofler ltinkl jgrulich
Branches: f18 f19
InitialCC:

Comment 6 Gwyn Ciesla 2013-08-14 12:55:46 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.