Red Hat Bugzilla – Bug 995003
'Vm' object has no attribute 'addVmToMonitoredDomains'
Last modified: 2016-02-10 12:11:37 EST
Created attachment 784321 [details] vdsm log Description of problem: Hotplug of a disk fails with the following error: Thread-520::ERROR::2013-08-08 10:54:18,006::BindingXMLRPC::993::vds::(wrapper) unexpected error Traceback (most recent call last): File "/usr/share/vdsm/BindingXMLRPC.py", line 979, in wrapper res = f(*args, **kwargs) File "/usr/share/vdsm/BindingXMLRPC.py", line 268, in vmHotplugDisk return vm.hotplugDisk(params) File "/usr/share/vdsm/API.py", line 431, in hotplugDisk return curVm.hotplugDisk(params) File "/usr/share/vdsm/vm.py", line 3263, in hotplugDisk self.addVmToMonitoredDomains(self.id, diskParams['domainID']) AttributeError: 'Vm' object has no attribute 'addVmToMonitoredDomains' Version-Release number of selected component (if applicable): is9, vdsm-4.12.0-37.gitfd6a1b7.el6ev.x86_64 How reproducible: 100% http://jenkins.qa.lab.tlv.redhat.com:8080/view/Storage/view/3.3/job/3.3-storage_hotplug_disk_hooks-iscsi-rest/45/ Steps to Reproduce: 1. try to hotplug a disk Actual results: action fails Expected results: action should succeed Additional info:
[root@puma17 ~]# grep -r ToMonitoredDomains /usr/share/vdsm /usr/share/vdsm/clientIF.py: def addVmToMonitoredDomains(self, vmId, domains): /usr/share/vdsm/vm.py: self.cif.addVmToMonitoredDomains(self.id, domains) /usr/share/vdsm/vm.py: self.addVmToMonitoredDomains(self.id, diskParams['domainID']) so probably it should be self.cif.addVmToMonitoredDomains(self.id, [diskParams['domainID']])
Seems to be a result of commit 87e61a0c57c1275f9cab3e523e02e51ed31c941f. Yeela, please take a look?
Actually, this was already fixed by 87e61a0c57c1275f9cab3e523e02e51ed31c941f. Therefore, no longer relevant.
Moving to MODIFIED so QA have the chance to verify this when a build is released.
Verified on is12: http://jenkins.qa.lab.tlv.redhat.com:8080/view/Storage/view/3.3/job/3.3-storage_hotplug_disk_hooks-iscsi-rest/91/consoleFull
This bug is currently attached to errata RHBA-2013:15291. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag. Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information: * Cause: What actions or circumstances cause this bug to present. * Consequence: What happens when the bug presents. * Fix: What was done to fix the bug. * Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore') Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug. For further details on the Cause, Consequence, Fix, Result format please refer to: https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes Thanks in advance.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0040.html