Red Hat Bugzilla – Bug 995754
webadmin [Tree]: fix hardcoded non-i18n strings in tree context info messages
Last modified: 2013-09-23 03:27:16 EDT
Description of problem:
In several model classes, there are hard-coded non-internationalized strings that are used to provide context help to the user.
innerHostModel.getName().setInfo("Cannot edit Host's Name in this tree context"); //$NON-NLS-1$
At current count there are about 20 of these in uicommonweb.
Steps to Reproduce:
1. Select a language other than English
2. Select an actual host in the tree.
3. Click edit.
4. You cannot edit the host, and the context help reason shown is in English.
The reason is in English.
These strings should be internationalized and not hardcoded. The reason should be in the user's selected language.
Step to Reproduce #4 should say
4. You cannot edit the host *name*, and the context help reason shown is in English.
*** Bug 995755 has been marked as a duplicate of this bug. ***
according to the comment posted in http://gerrit.ovirt.org/#/c/17886/, setInfo is deprecated and should be replaced with "setChangeProhibitionReason" (thanks Derez).
all occurrences of "setInfo" in uicommonweb should be replaced with "setChangeProhibitionReason", and while at it - be localized as well (i.e. extracted to UIConstants).
as RC is built, moving to ON_QA (hopefully did not catch incorrect bugs when doing this)
closing as this should be in 3.3 (doing so in bulk, so may be incorrect)