Bug 998420 - Option "-h" is missing for "oo-cgroup-template"
Summary: Option "-h" is missing for "oo-cgroup-template"
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Michal Fojtik
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-19 09:22 UTC by Qiushui Zhang
Modified: 2015-05-14 23:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-29 12:52:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Qiushui Zhang 2013-08-19 09:22:04 UTC
Description of problem:
If executing "oo-cgroup-template -h", it will say "/usr/bin/oo-cgroup-template: invalid option -- h". Both "-h/--help" should be the help option for the command.

Version-Release number of selected component (if applicable):
devenv_3672

How reproducible:
always

Steps to Reproduce:
1. On instance, do "oo-cgroup-template -h"
2. 
3.

Actual results:
[root@ip-10-154-135-205 ~]# oo-cgroup-template -h
/usr/bin/oo-cgroup-template: invalid option -- h
== Synopsis

/usr/bin/oo-cgroup-template: Enable cgroups for a gear
  This command must be run as root.

== Usage

To set a cgroup template for a gear with UUID:
/usr/bin/oo-cgroup-template --with-container-uuid UUID --template TEMPLATE

To set a cgroup template for all gears:
/usr/bin/oo-cgroup-template --with-all-containers --template TEMPLATE

To list the available cgroup templates:
/usr/bin/oo-cgroup-template --templates

To list the template for a gear with UUID:
/usr/bin/oo-cgroup-template --with-container-uuid UUID

Expected results:
Option "-h" should be an expected option for help content.

Additional info:

Comment 1 Michal Fojtik 2013-08-20 13:35:29 UTC
Fix here: https://github.com/openshift/origin-server/pull/3426

Comment 2 openshift-github-bot 2013-08-21 16:43:34 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/528d99b54ad81986e35e2e40e3c031b17d8bab77
Bug 998420 - Fixed typo in the --help option for oo-cgroup-template

Comment 3 Qiushui Zhang 2013-08-26 02:36:09 UTC
Tested on devenv_3706.

[root@ip-10-179-40-138 ~]# oo-cgroup-template -h
== Synopsis

/usr/bin/oo-cgroup-template: Enable cgroups for a gear
  This command must be run as root.

== Usage

To set a cgroup template for a gear with UUID:
/usr/bin/oo-cgroup-template --with-container-uuid UUID --template TEMPLATE

To set a cgroup template for all gears:
/usr/bin/oo-cgroup-template --with-all-containers --template TEMPLATE

To list the available cgroup templates:
/usr/bin/oo-cgroup-template --templates

To list the template for a gear with UUID:
/usr/bin/oo-cgroup-template --with-container-uuid UUID

== List of arguments
  -c|--with-container-uuid  gear_uuid   Unique identifier for the gears
  -a|--with-all-containers              Run on all gears
  -t|--template template                Template to set
  -s|--templates                        List templates
  -d|--debug                            Enable debug mode
  -h|--help                             Print this message

[root@ip-10-179-40-138 ~]# oo-cgroup-template --help
== Synopsis

/usr/bin/oo-cgroup-template: Enable cgroups for a gear
  This command must be run as root.

== Usage

To set a cgroup template for a gear with UUID:
/usr/bin/oo-cgroup-template --with-container-uuid UUID --template TEMPLATE

To set a cgroup template for all gears:
/usr/bin/oo-cgroup-template --with-all-containers --template TEMPLATE

To list the available cgroup templates:
/usr/bin/oo-cgroup-template --templates

To list the template for a gear with UUID:
/usr/bin/oo-cgroup-template --with-container-uuid UUID

== List of arguments
  -c|--with-container-uuid  gear_uuid   Unique identifier for the gears
  -a|--with-all-containers              Run on all gears
  -t|--template template                Template to set
  -s|--templates                        List templates
  -d|--debug                            Enable debug mode
  -h|--help                             Print this message

So mark it as fixed.


Note You need to log in before you can comment on or make changes to this bug.