Bug 998456 - Review Request: rubygem-protected_attributes - Protect attributes from mass assignment in Active Record models
Summary: Review Request: rubygem-protected_attributes - Protect attributes from mass a...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josef Stribny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 993224
TreeView+ depends on / blocked
 
Reported: 2013-08-19 11:11 UTC by Vít Ondruch
Modified: 2016-01-04 05:51 UTC (History)
3 users (show)

Fixed In Version: rubygem-protected_attributes-1.0.3-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-20 13:09:41 UTC
Type: ---
Embargoed:
jstribny: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Vít Ondruch 2013-08-19 11:11:55 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-protected_attributes.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-protected_attributes-1.0.3-1.fc20.src.rpm
Description: Protect attributes from mass assignment.
Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5828798

Comment 1 Josef Stribny 2013-08-19 11:12:55 UTC
Taking.

Comment 2 Josef Stribny 2013-08-19 12:07:56 UTC
* %{gem_instdir}/README.md could be marked as %doc.

Rpmlint doesn't complain, package builds, installs and I don't see any other issues with the specfile so I am APPROVING this package. Please consider fixing the issue above before pushing.

Comment 3 Vít Ondruch 2013-08-19 12:12:05 UTC
Thanks for the review!


New Package SCM Request
=======================
Package Name: rubygem-protected_attributes
Short Description: Protect attributes from mass assignment in Active Record models
Owners: vondruch
Branches: 
InitialCC:

Comment 4 Gwyn Ciesla 2013-08-19 12:41:59 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.