998975 – [engine-backend] EJBTransactionRolled backException when engine looses connection with spm before it was able to send AddVmFromTemplateCommand

Bug 998975 - [engine-backend] EJBTransactionRolled backException when engine looses connection with spm before it was able to send AddVmFromTemplateCommand

Summary: [engine-backend] EJBTransactionRolled backException when engine looses connec...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-engine
Sub Component:
Version:	3.3.0
Hardware:	x86_64
OS:	Unspecified
Priority:	unspecified
Severity:	medium
Target Milestone:	---
Target Release:	3.4.0
Assignee:	Roy Golan
QA Contact:
Docs Contact:
URL:
Whiteboard:	virt
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2013-08-20 12:56 UTC by Elad
Modified:	2014-03-27 10:40 UTC (History)
CC List:	8 users (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2014-03-27 10:40:02 UTC
oVirt Team:	---
Target Upstream Version:

Attachments	(Terms of Use)
logs (854.84 KB, application/x-gzip) 2013-08-20 12:56 UTC, Elad	no flags	Details
UI screenshot (33.75 KB, image/png) 2013-08-20 13:03 UTC, Elad	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Elad 2013-08-20 12:56:39 UTC

Created attachment 788482 [details]
logs

Description of problem:
When engine reports about VDSNetworkException before it was manage to send to spm CopyImageVDS, it throws an exception:

2013-08-20 15:33:08,100 ERROR [org.ovirt.engine.core.bll.AddVmFromTemplateCommand] (ajp-/127.0.0.1:8702-3) Command org.ovirt.engine.core.bll.AddVmFromTemplateCommand throw exception: javax.ejb.EJBTransactionRolledbackException: Could not get JDBC Connection; nested exception is java.sql.SQLException: javax.resource.ResourceException: IJ000460: Error checking for a transaction
        at org.jboss.as.ejb3.tx.CMTTxInterceptor.handleInCallerTx(CMTTxInterceptor.java:138) [jboss-as-ejb3.jar:7.2.0.Final-redhat-8]
        at org.jboss.as.ejb3.tx.CMTTxInterceptor.invokeInCallerTx(CMTTxInterceptor.java:228) [jboss-as-ejb3.jar:7.2.0.Final-redhat-8]
        at org.jboss.as.ejb3.tx.CMTTxInterceptor.supports(CMTTxInterceptor.java:376) [jboss-as-ejb3.jar:7.2.0.Final-redhat-8]
        at org.jboss.as.ejb3.tx.CMTTxInterceptor.processInvocation(CMTTxInterceptor.java:218) [jboss-as-ejb3.jar:7.2.0.Final-redhat-8]
        at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation.jar:1.1.1.Final-redhat-2]



Version-Release number of selected component (if applicable):
rhevm-3.3.0-0.15.master.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
On a block pool:
- create a vm from template and stop vdsm before the command is sent to spm


Actual results:
When vdsm crashes before engine send the CopyImage command, engine throws the mentioned exception. 
There are no leftovers of the new vm in the system, and spm selection ends successfully after this issue.

Expected results:
Engine should revert the AddVmFromTemplate without throwing these exception 

Additional info: logs

Comment 1 Elad 2013-08-20 13:03:58 UTC

Created attachment 788484 [details]
UI screenshot

Comment 2 Barak 2013-08-25 13:56:39 UTC

The only problem is seeing the exception in the log ?

Comment 3 Elad 2013-08-25 14:40:43 UTC

(In reply to Barak from comment #2)
> The only problem is seeing the exception in the log ?

yes

Comment 4 Barak 2013-08-26 14:23:22 UTC

per comment #3 moving to virt - this is not an infra issue

Comment 5 Roy Golan 2014-03-24 09:22:47 UTC

Elad this problem shouldn't occur sense the connection to a blocked VDSM should't take that long anymore. can you reproduce?

Comment 6 Elad 2014-03-27 10:10:25 UTC

(In reply to Roy Golan from comment #5)
> Elad this problem shouldn't occur sense the connection to a blocked VDSM
> should't take that long anymore. can you reproduce?

Roy, indeed, I'm not manage to reproduce

Comment 7 Roy Golan 2014-03-27 10:40:02 UTC

connection open timeout is down to 2 seconds in current release. this shouldn't happen anymore

Comment 8 Roy Golan 2014-03-27 10:40:24 UTC

connection open timeout is down to 2 seconds in current release. this shouldn't happen any more.

Note You need to log in before you can comment on or make changes to this bug.