Bug 999189 - If gear upgrade extension version does not match supplied version, it should not be loaded.
Summary: If gear upgrade extension version does not match supplied version, it should ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Paul Morie
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-20 21:52 UTC by Paul Morie
Modified: 2015-05-14 23:26 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-29 12:54:10 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Paul Morie 2013-08-20 21:52:56 UTC
Gear upgrade extension should be a no-op if it's for the wrong version (current behavior is to raise an exception).

Comment 1 Paul Morie 2013-08-21 16:51:59 UTC
PR submitted to master.

Comment 2 openshift-github-bot 2013-08-21 18:01:46 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/f7e50e2165cfe1e74ff5386179de3a6c1cbad73b
Fix bug 999189: gear upgrade extension is a no-op if release version doesn't match supplied version

Comment 4 Meng Bo 2013-08-22 10:32:22 UTC
Tested on devenv-stage_448, the patch should work fine.

# oo-admin-upgrade upgrade-gear --version 3.0.32 --app-name appa --login bmeng --upgrade-gear=5215e6c499055c0995000002

       "log": [
            "Version mismatch between supplied release version (3.0.32) and extension version (2.0.32", 

But there missing a ")" in the end of the message.

Assign it back to fix the typo.

Comment 5 Paul Morie 2013-08-22 14:42:38 UTC
PRs submitted to master and stage for this.

Comment 7 Meng Bo 2013-08-23 10:00:38 UTC
"log":["Version mismatch between supplied release version (2.0.33) and extension version (2.0.32)"

The typo fixed on devnev-stage_452.


Note You need to log in before you can comment on or make changes to this bug.