Bug 1011616 (CVE-2013-4367) - CVE-2013-4367 ovirt-engine: some config files left world-writable due to improper use of os.chmod()
Summary: CVE-2013-4367 ovirt-engine: some config files left world-writable due to impr...
Keywords:
Status: CLOSED NOTABUG
Alias: CVE-2013-4367
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1011619
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-24 16:12 UTC by Vincent Danen
Modified: 2019-09-29 13:08 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine 3.3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-27 08:47:42 UTC


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
oVirt gerrit 19557 None None None Never

Description Vincent Danen 2013-09-24 16:12:13 UTC
It was found that ovirt-engine would create certain files world-writable (such as /etc/sysconfig/nfs).  This is due to an upstream kernel change [1] which impacts how python's os.chmod() works when passed a mode of '-1'.  Prior to this kernel change, a mode of '-1' would have implied "do nothing", however with the upstream kernel change this will turn all possible bits on (thus making the file world-writable).

As a result, this only affects ovirt-engine (or other python scripts using os.chmod() in this way) with newer Linux kernels (version 3.1 and newer).

This has been in upstream git [2] to fix permissions on installations that upgrade from 3.2.  In 3.3, the entire setup package was rewritten and the copyFile() function (from common_utils.py, where this os.chmod() call is made) has been removed.  As a result, this only affects ovirt-engine 3.2 running on a Linux kernel 3.1+.


[1] https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/fs/open.c?id=e57712ebebbb9db7d8dcef216437b3171ddcf115
[2] http://gerrit.ovirt.org/#/c/19472/


Acknowledgements:

This issue was discovered by Yedidyah Bar David of Red Hat.

Comment 2 Vincent Danen 2013-09-24 16:15:44 UTC
Statement:

Not vulnerable.  This issue did not affect Red Hat Enterprise Virtualization Manager 3.

Comment 3 Vincent Danen 2013-09-24 16:16:11 UTC
Created ovirt-engine tracking bugs for this issue:

Affects: fedora-all [bug 1011619]

Comment 4 Vincent Danen 2013-10-09 15:58:22 UTC
Another fix noted here: http://gerrit.ovirt.org/#/c/19557/

Comment 5 Alon Bar-Lev 2014-03-26 20:18:39 UTC
Hi,

Can we close this? in 3.3 setup was re-written without using this -1 magic.


Note You need to log in before you can comment on or make changes to this bug.