Bug 1712569 (CVE-2019-10176) - CVE-2019-10176 atomic-openshift: CSRF tokens not refreshing while user is logged in and are exposed in the URL
Summary: CVE-2019-10176 atomic-openshift: CSRF tokens not refreshing while user is log...
Keywords:
Status: CLOSED ERRATA
Alias: CVE-2019-10176
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1723705 1702536 1723706
Blocks: 1712572
TreeView+ depends on / blocked
 
Reported: 2019-05-21 20:01 UTC by Pedro Sampaio
Modified: 2019-09-29 15:13 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
A flaw was found in OpenShift Container Platform, versions 3.11 and later, in which the CSRF tokens used in the cluster console component were found to remain static during a user's session. An attacker with the ability to observe the value of this token would be able to re-use the token to perform a CSRF attack.
Clone Of:
Environment:
Last Closed: 2019-07-09 14:14:08 UTC


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:2792 None None None 2019-09-17 18:12:06 UTC

Description Pedro Sampaio 2019-05-21 20:01:09 UTC
A flaw was found in atomic-openshift. CSRF tokens are not refreshing while a user is logged in, and they are exposed in the URL. This may allow attackers to perform CSRF attacks successfully.

Comment 1 Dave Baker 2019-06-25 08:17:32 UTC
Statement:

OpenShift Container Platform versions prior to 3.11 do not contain the affected "cluster console" component and are not vulnerable to this flaw.

Comment 4 Dave Baker 2019-06-25 08:22:45 UTC
Acknowledgments:

Name: Jeremy Choi (Red Hat)

Comment 5 Dave Baker 2019-06-25 10:38:39 UTC
From OWASP docs: https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.md

firstly, the docs indicate that a CSRF per session is adequate in general
- "Any state changing operation requires a secure random token (e.g., CSRF token) to prevent CSRF attacks. A CSRF token should be unique per user session"

secondly, it's noted that a CSRF per request offers additional security:
- "To further enhance the security of this proposed design, consider randomizing the CSRF token parameter name and/or value for each request."


To restate the original concern, the issue is not that CSRF tokens do not change; it is that they are exposed in the URL.  Rotating the tokens would be a mitigation for the concern given that websockets requests cannot have them embedded in a custom header.

Comment 9 Dave Baker 2019-09-13 20:12:46 UTC
I have updated the affected component to the more specific "openshift-enterprise-console-container" for the three affected releases.

Comment 10 errata-xmlrpc 2019-09-17 18:12:04 UTC
This issue has been addressed in the following products:

  Red Hat OpenShift Container Platform 4.1

Via RHSA-2019:2792 https://access.redhat.com/errata/RHSA-2019:2792


Note You need to log in before you can comment on or make changes to this bug.