Bug 1746225 (CVE-2019-10197) - CVE-2019-10197 samba: Combination of parameters and permissions can allow user to escape from the share path definition
Summary: CVE-2019-10197 samba: Combination of parameters and permissions can allow use...
Keywords:
Status: NEW
Alias: CVE-2019-10197
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1746240 1746241 1746244 1748308
Blocks: 1746226
TreeView+ depends on / blocked
 
Reported: 2019-08-28 02:33 UTC by Huzaifa S. Sidhpurwala
Modified: 2019-09-09 14:06 UTC (History)
24 users (show)

Fixed In Version: samba 4.9.13, samba 4.10.8, samba 4.11.0rc3
Doc Type: If docs needed, set a value
Doc Text:
A flaw was found in samba when certain parameters were set in the samba configuration file. An unauthenticated attacker could use this flaw to escape the shared directory and access the contents of directories outside of the share.
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Samba Project 14035 None None None 2019-08-28 14:29:48 UTC

Description Huzaifa S. Sidhpurwala 2019-08-28 02:33:14 UTC
As per upstream advisory:

On a Samba SMB server for all versions of Samba from 4.9.0 clients are able to escape outside the share root directory if certain configuration parameters set in the smb.conf file.

The problem is reproducable if the 'wide links' option is explicitly set to 'yes' and either 'unix extensions = no' or 'allow insecure wide links = yes' is set in addition.

If a client has no permissions to enter the share root directory it will get ACCESS_DENIED on the first request. However smbd has a cache that remembers if it successfully changed to a directory. This cache was not being reset on failure. The following SMB request will then silently operate in the wrong directory instead of returning ACCESS_DENIED. That directory is either the share root directory of a different share the client was operating on successfully before or the global root directory ('/') of the system.

The unix token (uid, gid, list of groups) is always correctly impersonated before each operation, so the client is still restricted by the unix permissions enfored by the kernel.

Comment 1 Huzaifa S. Sidhpurwala 2019-08-28 02:33:21 UTC
Acknowledgments:

Name: Stefan Metzmacher (SerNet)

Comment 2 Huzaifa S. Sidhpurwala 2019-08-28 02:45:19 UTC
Mitigation:

The following methods can be used as a mitigation (only one is needed):
1. Use the 'sharesec' tool to configure a security descriptor for the share that's at least as strict as the permissions on the share root  directory.
2. Use the 'valid users' option to allow only users/groups which are able to enter the share root directory.
3. Remove 'wide links = yes' if it's not really needed.
4. In some situations it might be an option to use 'chmod a+x' on the share root directory, but you need to make sure that files and subdirectories are protected by stricter permissions. You may also want to 'chmod a-w' in order to prevent new top level files and directories, which may have less restrictive permissions.

Comment 3 Huzaifa S. Sidhpurwala 2019-08-28 02:50:00 UTC
Note:

Only the following configurations are affected:
If the 'wide links' option is explicitly set to 'yes' and either 'unix extensions = no' or 'allow insecure wide links = yes' is set in addition.

Also the attack is restricted by usual Linux DAC permissions e.g. file permissions on the resource. Further selinux permissions may also restrict the ability of the attacker to view/change files outside the usual share path.

Comment 7 Doran Moppert 2019-08-28 05:33:13 UTC
Statement:

Only samba configurations where 'wide links' option is explicitly set to 'yes' is affected by this flaw. Therefore default configurations of samba package shipped with Red Hat Products are not affected.

This vulnerability exists in the samba server, client side packages are not affected.

Comment 8 Doran Moppert 2019-08-29 05:01:07 UTC
External References:

https://www.samba.org/samba/security/CVE-2019-10197.html

Comment 9 Siddharth Sharma 2019-09-03 10:54:22 UTC
Created samba tracking bugs for this issue:

Affects: fedora-all [bug 1748308]


Note You need to log in before you can comment on or make changes to this bug.