Bug 1781953 (CVE-2019-1348) - CVE-2019-1348 git: Arbitrary path overwriting via export-marks in-stream command feature
Summary: CVE-2019-1348 git: Arbitrary path overwriting via export-marks in-stream comm...
Keywords:
Status: CLOSED ERRATA
Alias: CVE-2019-1348
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1784527 1781955 1784526 1784528 1785182 1785183
Blocks: 1781145
TreeView+ depends on / blocked
 
Reported: 2019-12-10 23:52 UTC by Pedro Sampaio
Modified: 2020-01-27 08:54 UTC (History)
18 users (show)

Fixed In Version: git 2.24.1, git 2.23.1, git 2.22.2, git 2.21.1, git 2.20.2, git 2.19.3, git 2.18.2, git 2.17.3, git 2.16.6, git 2.15.4, git 2.14.6
Doc Type: If docs needed, set a value
Doc Text:
A flaw was found in the git fast-import command where it provides the export-marks feature that may unexpectedly overwrite arbitrary paths. An attacker can abuse this flaw if they can control the input passed to the fast-import command by using the export-marks feature and overwrite arbitrary files, but would not have complete control on the content of the file.
Clone Of:
Environment:
Last Closed: 2019-12-19 20:09:42 UTC


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:0003 None None None 2020-01-02 10:58:34 UTC
Red Hat Product Errata RHBA-2020:0025 None None None 2020-01-06 13:23:15 UTC
Red Hat Product Errata RHBA-2020:0032 None None None 2020-01-06 21:07:06 UTC
Red Hat Product Errata RHBA-2020:0125 None None None 2020-01-16 13:09:49 UTC
Red Hat Product Errata RHSA-2019:4356 None None None 2019-12-19 18:43:57 UTC
Red Hat Product Errata RHSA-2020:0002 None None None 2020-01-02 08:54:01 UTC
Red Hat Product Errata RHSA-2020:0228 None None None 2020-01-27 08:54:20 UTC

Description Pedro Sampaio 2019-12-10 23:52:06 UTC
The --export-marks option of git fast-import is exposed also via the in-stream command feature export-marks=... and it allows overwriting arbitrary paths.

References:

https://kernel.googlesource.com/pub/scm/git/git/+/refs/tags/v2.24.1/Documentation/RelNotes/2.14.6.txt

Comment 1 Pedro Sampaio 2019-12-11 00:00:54 UTC
Created git tracking bugs for this issue:

Affects: fedora-all [bug 1781955]

Comment 2 Riccardo Schirone 2019-12-13 16:40:58 UTC
oss-security mailing list reference:
https://www.openwall.com/lists/oss-security/2019/12/13/1

Comment 3 Riccardo Schirone 2019-12-13 16:42:18 UTC
External References:

https://github.com/git/git/security/advisories/GHSA-2pw3-gwg9-8pqr

Comment 4 Riccardo Schirone 2019-12-13 16:47:26 UTC
Upstream fix:
https://github.com/git/git/commit/68061e3470210703cb15594194718d35094afdc0

Comment 5 Riccardo Schirone 2019-12-17 15:39:32 UTC
Mitigation:

Avoid running `git fast-import` on untrusted input.

Comment 8 Riccardo Schirone 2019-12-17 17:55:44 UTC
Command `git fast-import` accepts, among other things, the in-stream command `feature export-marks=<path>`, which lets the stream write marks to an arbitrary path. If an attacker can control the input stream, he could overwrite an arbitrary path, though he could not fully control the content of the file because it has a standard format (each line is of the form `:markid SHA-1`).

Comment 10 errata-xmlrpc 2019-12-19 18:43:56 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8

Via RHSA-2019:4356 https://access.redhat.com/errata/RHSA-2019:4356

Comment 11 Product Security DevOps Team 2019-12-19 20:09:42 UTC
This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2019-1348

Comment 12 errata-xmlrpc 2020-01-02 08:53:57 UTC
This issue has been addressed in the following products:

  Red Hat Software Collections for Red Hat Enterprise Linux 7
  Red Hat Software Collections for Red Hat Enterprise Linux 7.6 EUS
  Red Hat Software Collections for Red Hat Enterprise Linux 7.5 EUS
  Red Hat Software Collections for Red Hat Enterprise Linux 7.7 EUS

Via RHSA-2020:0002 https://access.redhat.com/errata/RHSA-2020:0002

Comment 16 errata-xmlrpc 2020-01-27 08:54:18 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8.0 Update Services for SAP Solutions

Via RHSA-2020:0228 https://access.redhat.com/errata/RHSA-2020:0228


Note You need to log in before you can comment on or make changes to this bug.