Bug 1835382 (CVE-2020-11042) - CVE-2020-11042 freerdp: out-of-bounds read in update_read_icon_info function
Summary: CVE-2020-11042 freerdp: out-of-bounds read in update_read_icon_info function
Keywords:
Status: CLOSED ERRATA
Alias: CVE-2020-11042
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1835383 1835384 1835385 1836381 1836382
Blocks: 1835410
TreeView+ depends on / blocked
 
Reported: 2020-05-13 17:36 UTC by Guilherme de Almeida Suckevicz
Modified: 2020-11-04 02:38 UTC (History)
4 users (show)

Fixed In Version: freerdp 2.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-29 22:00:58 UTC


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2020:4031 0 None None None 2020-09-29 20:43:36 UTC
Red Hat Product Errata RHSA-2020:4647 0 None None None 2020-11-04 02:38:36 UTC

Description Guilherme de Almeida Suckevicz 2020-05-13 17:36:11 UTC
In FreeRDP greater than 1.1 and before 2.0.0, there is an out-of-bounds read in update_read_icon_info. It allows reading a attacker-defined amount of client memory (32bit unsigned -> 4GB) to an intermediate buffer. This can be used to crash the client or store information for later retrieval. This has been patched in 2.0.0.

References:
https://github.com/FreeRDP/FreeRDP/issues/6010
https://github.com/FreeRDP/FreeRDP/security/advisories/GHSA-9jp6-5vf2-cx2q

Upstream commit:
https://github.com/FreeRDP/FreeRDP/commit/6b2bc41935e53b0034fe5948aeeab4f32e80f30f

Comment 1 Guilherme de Almeida Suckevicz 2020-05-13 17:36:34 UTC
Created freerdp tracking bugs for this issue:

Affects: epel-all [bug 1835385]
Affects: fedora-all [bug 1835383]


Created freerdp1.2 tracking bugs for this issue:

Affects: fedora-all [bug 1835384]

Comment 2 Todd Cullum 2020-05-14 23:44:36 UTC
Technical details
===================

In window.c of FreeRDP's libfreerdp, the update_read_icon_info() routine reads from a stream. In an attempt to prevent from overflowing the stream buffer, the function calls Stream_GetRemainingLength(s). However, it only checks the length against two of the reads that it intends to make (iconInfo->cbBitsMask + iconInfo->cbBitsColor). The third read is into iconInfo->ColorTable, the length of which is never checked. Thus, if the iconInfo->cbColorTable is too large, an out-of-bounds read can occur where the program attempts to read past the end of the stream buffer on the heap, into iconInfo->ColorTable.

Comment 7 errata-xmlrpc 2020-09-29 20:43:33 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 7

Via RHSA-2020:4031 https://access.redhat.com/errata/RHSA-2020:4031

Comment 8 Product Security DevOps Team 2020-09-29 22:00:58 UTC
This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2020-11042

Comment 9 errata-xmlrpc 2020-11-04 02:38:35 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8

Via RHSA-2020:4647 https://access.redhat.com/errata/RHSA-2020:4647


Note You need to log in before you can comment on or make changes to this bug.