Bug 1999745 (CVE-2021-39135) - CVE-2021-39135 nodejs-arborist: symlink following vulnerability
Summary: CVE-2021-39135 nodejs-arborist: symlink following vulnerability
Keywords:
Status: NEW
Alias: CVE-2021-39135
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
high
high
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 2029557
Blocks: 1999749
TreeView+ depends on / blocked
 
Reported: 2021-08-31 16:55 UTC by Guilherme de Almeida Suckevicz
Modified: 2021-12-07 09:47 UTC (History)
11 users (show)

Fixed In Version: nodejs-npmcli-arborist 2.8.2, npm 7.21.0
Doc Type: If docs needed, set a value
Doc Text:
A flaw was found in nodejs-arborist. Arborist could write package dependencies to any arbitrary location on the file system if an attacker had replaced a project folder with a symbolic link in the node_modules folder. The highest threat from this vulnerability is to data integrity and system availability.
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Guilherme de Almeida Suckevicz 2021-08-31 16:55:46 UTC
@npmcli/arborist, the library that calculates dependency trees and manages the node_modules folder hierarchy for the npm command line interface, aims to guarantee that package dependency contracts will be met, and the extraction of package contents will always be performed into the expected folder.

This is accomplished by extracting package contents into a project's node_modules folder.

If the node_modules folder of the root project or any of its dependencies is somehow replaced with a symbolic link, it could allow Arborist to write package dependencies to any arbitrary location on the file system.

Note that symbolic links contained within package artifact contents are filtered out, so another means of creating a node_modules symbolic link would have to be employed.

A preinstall script could replace node_modules with a symlink. (This is prevented by using --ignore-scripts.)
An attacker could supply the target with a git repository, instructing them to run npm install --ignore-scripts in the root. This may be successful, because npm install --ignore-scripts is typically not capable of making changes outside of the project directory, so it may be deemed safe.

Reference:
https://github.com/npm/arborist/security/advisories/GHSA-gmw6-94gg-2rc2

Comment 2 Laurie Morse 2021-09-24 15:19:09 UTC
Searched Red Hat - This CVE page does not exist - https://access.redhat.com/security/cve/CVE-2021-39135

Any idea when Red Hat will open a CVE record and include this fix?

Comment 4 Cedric Buissart 2021-12-06 15:20:14 UTC
In reply to comment #2:
> Searched Red Hat - This CVE page does not exist -
> https://access.redhat.com/security/cve/CVE-2021-39135
> 
> Any idea when Red Hat will open a CVE record and include this fix?
The page should now exist

Comment 5 Cedric Buissart 2021-12-06 15:47:19 UTC
* npm versions v7 until older than v7.21.0 are affected
* npm versions v7.21.0 and newer (including v8.0.0) are not affected
* npm versions 6.x and older are not using @npmcli/arborist, and thus are not affected

Comment 7 Cedric Buissart 2021-12-06 18:46:57 UTC
Created nodejs:16/nodejs tracking bugs for this issue:

Affects: fedora-all [bug 2029557]


Note You need to log in before you can comment on or make changes to this bug.