Bug 2265652 (CVE-2023-52447) - CVE-2023-52447 kernel: bpf: Defer the free of inner map when necessary [NEEDINFO]
Summary: CVE-2023-52447 kernel: bpf: Defer the free of inner map when necessary
Keywords:
Status: NEW
Alias: CVE-2023-52447
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 2265670
Blocks: 2265643
TreeView+ depends on / blocked
 
Reported: 2024-02-23 13:47 UTC by Patrick Del Bello
Modified: 2024-06-19 14:32 UTC (History)
50 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Embargoed:
allarkin: needinfo? (vinair)


Attachments (Terms of Use)

Description Patrick Del Bello 2024-02-23 13:47:34 UTC
bpf: Defer the free of inner map when necessary

When updating or deleting an inner map in map array or map htab, the map
may still be accessed by non-sleepable program or sleepable program.
However bpf_map_fd_put_ptr() decreases the ref-counter of the inner map
directly through bpf_map_put(), if the ref-counter is the last one
(which is true for most cases), the inner map will be freed by
ops->map_free() in a kworker. But for now, most .map_free() callbacks
don't use synchronize_rcu() or its variants to wait for the elapse of a
RCU grace period, so after the invocation of ops->map_free completes,
the bpf program which is accessing the inner map may incur
use-after-free problem.

Fix the free of inner map by invoking bpf_map_free_deferred() after both
one RCU grace period and one tasks trace RCU grace period if the inner
map has been removed from the outer map before. The deferment is
accomplished by using call_rcu() or call_rcu_tasks_trace() when
releasing the last ref-counter of bpf map. The newly-added rcu_head
field in bpf_map shares the same storage space with work field to
reduce the size of bpf_map.

Comment 1 Patrick Del Bello 2024-02-23 14:56:00 UTC
Created kernel tracking bugs for this issue:

Affects: fedora-all [bug 2265670]

Comment 3 Justin M. Forbes 2024-02-27 00:25:04 UTC
	Issue introduced in 5.9 with commit 638e4b825d52 and fixed in 6.1.75 with commit 62fca83303d6
	Issue introduced in 5.9 with commit 638e4b825d52 and fixed in 6.6.14 with commit f91cd728b10c
	Issue introduced in 5.9 with commit 638e4b825d52 and fixed in 6.7.2 with commit bfd9b20c4862
	Issue introduced in 5.9 with commit 638e4b825d52 and fixed in 6.8-rc1 with commit 876673364161

Comment 4 Justin M. Forbes 2024-02-27 00:25:37 UTC
This was fixed for Fedora with the 6.6.14 stable kernel updates.

Comment 6 Alex 2024-06-09 16:34:53 UTC
The result of automatic check (that is developed by Alexander Larkin) for this CVE-2023-52447 is: CHECK	Maybe valid. Check manually. with impact LOW (that is an approximation based on flags INIT BPF UAF  ; these flags parsed automatically based on patch data). Such automatic check happens only for Low/Moderates (and only when not from reporter, but parsing already existing CVE). Highs always checked manually (I check it myself and then we check it again in Remediation team). In rare cases some of the Moderates could be increased to High later.


Note You need to log in before you can comment on or make changes to this bug.