Bug 2330343 (CVE-2024-53130) - CVE-2024-53130 kernel: nilfs2: fix null-ptr-deref in block_dirty_buffer tracepoint
Summary: CVE-2024-53130 kernel: nilfs2: fix null-ptr-deref in block_dirty_buffer trace...
Keywords:
Status: NEW
Alias: CVE-2024-53130
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Product Security DevOps Team
QA Contact:
URL:
Whiteboard:
Depends On: 2330501
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-04 15:01 UTC by OSIDB Bzimport
Modified: 2024-12-05 04:59 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description OSIDB Bzimport 2024-12-04 15:01:41 UTC
In the Linux kernel, the following vulnerability has been resolved:

nilfs2: fix null-ptr-deref in block_dirty_buffer tracepoint

When using the "block:block_dirty_buffer" tracepoint, mark_buffer_dirty()
may cause a NULL pointer dereference, or a general protection fault when
KASAN is enabled.

This happens because, since the tracepoint was added in
mark_buffer_dirty(), it references the dev_t member bh->b_bdev->bd_dev
regardless of whether the buffer head has a pointer to a block_device
structure.

In the current implementation, nilfs_grab_buffer(), which grabs a buffer
to read (or create) a block of metadata, including b-tree node blocks,
does not set the block device, but instead does so only if the buffer is
not in the "uptodate" state for each of its caller block reading
functions.  However, if the uptodate flag is set on a folio/page, and the
buffer heads are detached from it by try_to_free_buffers(), and new buffer
heads are then attached by create_empty_buffers(), the uptodate flag may
be restored to each buffer without the block device being set to
bh->b_bdev, and mark_buffer_dirty() may be called later in that state,
resulting in the bug mentioned above.

Fix this issue by making nilfs_grab_buffer() always set the block device
of the super block structure to the buffer head, regardless of the state
of the buffer's uptodate flag.

Comment 1 Avinash Hanwate 2024-12-05 04:34:59 UTC
Upstream advisory:
https://lore.kernel.org/linux-cve-announce/2024120450-CVE-2024-53130-5621@gregkh/T


Note You need to log in before you can comment on or make changes to this bug.