Bug 2334515 (CVE-2024-56568) - CVE-2024-56568 kernel: iommu/arm-smmu: Defer probe of clients after smmu device bound
Summary: CVE-2024-56568 kernel: iommu/arm-smmu: Defer probe of clients after smmu devi...
Keywords:
Status: NEW
Alias: CVE-2024-56568
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Product Security DevOps Team
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-27 15:07 UTC by OSIDB Bzimport
Modified: 2024-12-29 04:44 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description OSIDB Bzimport 2024-12-27 15:07:07 UTC
In the Linux kernel, the following vulnerability has been resolved:

iommu/arm-smmu: Defer probe of clients after smmu device bound

Null pointer dereference occurs due to a race between smmu
driver probe and client driver probe, when of_dma_configure()
for client is called after the iommu_device_register() for smmu driver
probe has executed but before the driver_bound() for smmu driver
has been called.

Following is how the race occurs:

T1:Smmu device probe		T2: Client device probe

really_probe()
arm_smmu_device_probe()
iommu_device_register()
					really_probe()
					platform_dma_configure()
					of_dma_configure()
					of_dma_configure_id()
					of_iommu_configure()
					iommu_probe_device()
					iommu_init_device()
					arm_smmu_probe_device()
					arm_smmu_get_by_fwnode()
						driver_find_device_by_fwnode()
						driver_find_device()
						next_device()
						klist_next()
						    /* null ptr
						       assigned to smmu */
					/* null ptr dereference
					   while smmu->streamid_mask */
driver_bound()
	klist_add_tail()

When this null smmu pointer is dereferenced later in
arm_smmu_probe_device, the device crashes.

Fix this by deferring the probe of the client device
until the smmu device has bound to the arm smmu driver.

[will: Add comment]

Comment 1 Avinash Hanwate 2024-12-29 04:38:11 UTC
Upstream advisory:
https://lore.kernel.org/linux-cve-announce/2024122715-CVE-2024-56568-76a5@gregkh/T

Comment 3 Avinash Hanwate 2024-12-29 04:42:06 UTC
Upstream advisory:
https://lore.kernel.org/linux-cve-announce/2024122715-CVE-2024-56568-76a5@gregkh/T


Note You need to log in before you can comment on or make changes to this bug.