Include scripts that will copy over jboss.identity, inventory.dat, and application-versions.dat from a previous Agent installation.
Done - r1032.
inventory.dat is being kept to maintain manually added resources in the agent inventory, and also resource connection properties e.g. JBAS jmx credentials. The connection props would otherwise need to get pushed down again from the server and manually added resources deleted from the server side and re-added
The application-versions.dat file is JBoss ON specific file; more specifically it is an artifact of the JBoss AS plugin. It is a temporary workaround for EAR/WAR packages due to the lack of version-less content support. This file is a cache of EAR/WAR versions that have been discovered and upgraded. Without this file, we will effectively reset the versions of any upgraded EAR/WAR files the user deployed. The current scripts assume that file will be present. That won't be the case for pure RHQ installations. However, since we have yet to expose the binaries, I'm not too worried about this JBoss ON specific piece in the RHQ code base.
jboss.identity is kept to try to ensure the jboss remoting communication layer is not confused by the agent upgrade. From the remoting docs: "org.jboss.remoting.ident.Identity - is one of the main components remoting uses during discovery to identify remoting server instances (is actually the way it guarantees uniqueness). If have two remoting servers running on the same server, they can be uniquely identified. The reason the identity is persisted (currently only able to do this to the file system) is so if a server crashes and then restarts, can identify it when it restarts as the one that crashed (instead of being a completely new instance that is being started). This may be important from a monitoring point as would want to know that the crashed server is back online."
This did work for me with CR7
Let QA close this when they're comfortable the scripts work.
worked fine in CR7. "Just for an idea .. it could be better if you could include it in the command line option for the rhq-agent.sh script instead of separate upgrade,sh script"
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-617