Bug 452806 - (ember-media) Review Request: ember-media - media files for the ember
Review Request: ember-media - media files for the ember
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tom "spot" Callaway
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-25 04:01 EDT by Alexey Torkhov
Modified: 2008-09-12 03:26 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-09-12 03:26:21 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tcallawa: fedora‑review+


Attachments (Terms of Use)
spec changes to cleanup rpmlint failures (1.84 KB, patch)
2008-09-11 15:28 EDT, Tom "spot" Callaway
no flags Details | Diff

  None (edit)
Description Alexey Torkhov 2008-06-25 04:01:59 EDT
Spec URL: http://purple.worldforge.org/~alex/fedora/ember-media.spec
SRPM URL: http://purple.worldforge.org/~alex/fedora/ember-media-0.5.2-1.src.rpm (big package, 115M)
Description: Media files for the ember WorldForge client.

Non-free pack in tarball is reported upstream and would be fixed in next version.
Comment 1 Rudolf Kastl 2008-07-03 16:31:15 EDT
there is a typo:

Requires:       ember >= ${version}

should be:

Requires:       ember >= %{version}
Comment 2 Alexey Torkhov 2008-07-04 13:05:36 EDT
Thanks. I'm mixing $ and % quite often :)
Comment 5 Tom "spot" Callaway 2008-09-11 15:28:25 EDT
Created attachment 316476 [details]
spec changes to cleanup rpmlint failures
Comment 6 Tom "spot" Callaway 2008-09-11 15:39:58 EDT
I've attached a diff between your last spec file, and one I edited to fix the rpmlint errors:

This review is against the fixed spec and SRPM. Please make those changes before committing.

Good:

- rpmlint checks return:
ember-media.noarch: W: dangling-relative-symlink /usr/share/ember/media/shared/common/themes/ember/gui/fonts/VeraBd.ttf ../../../../../../../../fonts/bitstream-vera/VeraBd.ttf
ember-media.noarch: W: dangling-relative-symlink /usr/share/ember/media/shared/common/themes/ember/gui/fonts/Vera.ttf ../../../../../../../../fonts/bitstream-vera/Vera.ttf
ember-media.noarch: W: dangling-relative-symlink /usr/share/ember/media/shared/core/Vera.ttf ../../../../fonts/bitstream-vera/Vera.ttf

These are safe to ignore, because you have Requires: bitstream-vera-fonts

- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+ or GFDL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (1bd54d49063505c63ea9f4548711749b7e75a553)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- content okay
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Please be sure you make my changes before you commit, but this is APPROVED.
Comment 7 Alexey Torkhov 2008-09-11 16:27:16 EDT
Will apply your patch! Thanks!

New Package CVS Request
=======================
Package Name: ember-media
Short Description: Ember media files
Owners: atorkhov wart
Branches: F-9
InitialCC:
Comment 8 Huzaifa S. Sidhpurwala 2008-09-11 23:24:29 EDT
cvs done
Comment 9 Alexey Torkhov 2008-09-12 01:57:24 EDT
Huzaifa, package is in place, but I cannot find cvs module.
Comment 10 Alexey Torkhov 2008-09-12 02:01:57 EDT
Resolved in IRC.

Note You need to log in before you can comment on or make changes to this bug.