Bug 989359 - (gimp-paint-studio) Review Request: gimp-paint-studio - A collection of tool option presets and brushes for GIMP
Review Request: gimp-paint-studio - A collection of tool option presets and b...
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Christopher Meng
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-29 02:55 EDT by Luya Tshimbalanga
Modified: 2013-10-03 13:38 EDT (History)
2 users (show)

See Also:
Fixed In Version: gimp-paint-studio-2.0-6.el6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-08-24 18:28:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
i: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Luya Tshimbalanga 2013-07-29 02:55:49 EDT
Spec URL: http://luya.fedorapeople.org/packages/SPECS/gimp-paint-studio.spec
SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/gimp-paint-studio-2.0-3.fc19.src.rpm
Description: A collection of tool option presets and brushes for GIMP
designed for artists and graphics designers
Fedora Account System Username: luya
Comment 1 Christopher Meng 2013-08-13 00:14:25 EDT
- Remove %defattr(-,root,root,-)

- %_datadir --> %{_datadir}

- Remove commented lines.

- cp -a --> cp -pa

- %_datadir/gimp/2.0/brushes/GPS-Brushes/* and such lines in %files:

seems you forgot to own the dir itself, change to:

%{_datadir}/gimp/2.0/brushes/GPS-Brushes/

- %description not good, suggesstion:

GIMP Paint Studio(GPS) is a collection of brushes and accompanying tool presets. Tool presets are a simply saved tool options, highly useful feature of the GIMP. The goal of GPS is to provide an adequate working environment for graphic designers and artists to begin to paint and feel comfortable with GIMP from their first use.

- I see the %{url} is:

http://gps-gimp-paint-studio.googlecode.com/files/GPS 2_0 final.zip

should use %20 to replace the space " ". But not sure if this is my browser's problem.

- Please check if CCPL things are included.
Comment 2 Luya Tshimbalanga 2013-08-13 02:25:18 EDT
(In reply to Christopher Meng from comment #1)
> - Remove %defattr(-,root,root,-)
Done

> - %_datadir --> %{_datadir}
Good catch, an oversight of my part. Fixed

> - Remove commented lines.
Done

> - cp -a --> cp -pa
Done although -a should preserve all attributes according to man cp

 
> - %_datadir/gimp/2.0/brushes/GPS-Brushes/* and such lines in %files:
> 
> seems you forgot to own the dir itself, change to:
> 
> %{_datadir}/gimp/2.0/brushes/GPS-Brushes/
Done


> - %description not good, suggesstion:
> 
> GIMP Paint Studio(GPS) is a collection of brushes and accompanying tool
> presets. Tool presets are a simply saved tool options, highly useful feature
> of the GIMP. The goal of GPS is to provide an adequate working environment
> for graphic designers and artists to begin to paint and feel comfortable
> with GIMP from their first use.

Done

> - I see the %{url} is:
> 
> http://gps-gimp-paint-studio.googlecode.com/files/GPS 2_0 final.zip
> 
> should use %20 to replace the space " ". But not sure if this is my
> browser's problem.
rpmlint falsely claimed the above url is not found. %20 characters now replace the space " ".

 
> - Please check if CCPL things are included.
CCPL?
Comment 3 Luya Tshimbalanga 2013-08-13 03:47:42 EDT
Updates based on the feedback:

Spec URL: http://luya.fedorapeople.org/packages/SPECS/gimp-paint-studio.spec
SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/gimp-paint-studio-2.0-4.fc19.src.rpm

$ rpmlint rpmbuild/SRPMS/gimp-paint-studio-2.0-4.fc19.src.rpm 
gimp-paint-studio.src: W: no-%build-section
gimp-paint-studio.src: W: invalid-url Source0: http://gps-gimp-paint-studio.googlecode.com/files/GPS 2_0 final.zip HTTP Error 400: Bad Request
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint version used in from F19. The invalid url is a false negative despite the inclusion of %20 characters.
Comment 4 Christopher Meng 2013-08-13 03:57:20 EDT
And what's this:

find %{buildroot}%{_datadir}/gimp/2.0 

Also

Have you checked this file?

http://gps-gimp-paint-studio.googlecode.com/files/sessionrc

And, where is the license file?
Comment 5 Luya Tshimbalanga 2013-08-13 14:48:32 EDT
(In reply to Christopher Meng from comment #4)
> And what's this:
> 
> find %{buildroot}%{_datadir}/gimp/2.0 
That was used to check the integrity of files. Removed.


> Also
> 
> Have you checked this file?
> 
> http://gps-gimp-paint-studio.googlecode.com/files/sessionrc
This is an optional GPS dialog file overwritting the existing sessionrc in Gimp. Read the manual on https://code.google.com/p/gps-gimp-paint-studio/downloads/detail?name=GPS_Gimp%20Paint%20Studio%201_2%20manual.odt
Should I include it?

> 
> And, where is the license file?
I sent the email to upstream for that request. Alternately, should I include the file license when upstream specify the it on their website?
Comment 6 Luya Tshimbalanga 2013-08-14 05:46:49 EDT
Upstream was kind to include license files.

New update:
Spec URL: http://luya.fedorapeople.org/packages/SPECS/gimp-paint-studio.spec
SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/gimp-paint-studio-2.0-5.fc19.src.rpm

Note that fedora-review falsely assumes the non-existent url which actually works. sessionrc from upstream is optional and not required because it overwrites the existing sessionrc from Gimp.
Comment 7 Christopher Meng 2013-08-14 06:15:38 EDT
mkdir -p %{buildroot}%{_datadir}/gimp/2.0
You use datadir when mkdir, but don't use it when cp. You can fix it(optional):

%{buildroot}/usr/share/gimp/2.0

And, before going to approve your package, I want to know if CCPL is compatible with GPL. This is really painful, I hope you can get in touch with Tom or other guys. 

Cheers.
Comment 8 Luya Tshimbalanga 2013-08-14 11:40:10 EDT
(In reply to Christopher Meng from comment #7)
> mkdir -p %{buildroot}%{_datadir}/gimp/2.0
> You use datadir when mkdir, but don't use it when cp. You can fix
> it(optional):
> 
> %{buildroot}/usr/share/gimp/2.0
> 
> And, before going to approve your package, I want to know if CCPL is
> compatible with GPL. This is really painful, I hope you can get in touch
> with Tom or other guys. 
> 
> Cheers.

GPL is for the code like tool-presets and CCPL is for the content like brushes, dynamics, palettes and patterns.
Comment 9 Christopher Meng 2013-08-14 20:04:14 EDT
Ok.

Easy, simple, stay cool. 

APPROVED. 

If you have any design team goods for me,  just tell me.
Comment 10 Luya Tshimbalanga 2013-08-14 22:22:45 EDT
(In reply to Christopher Meng from comment #9)
> 
> If you have any design team goods for me,  just tell me.

Thank you Christopher. I will definitely let you know.
Comment 11 Luya Tshimbalanga 2013-08-14 22:27:56 EDT
New Package SCM Request
=======================
Package Name: gimp-paint-studio
Short Description: A collection of tool option presets and brushes for GIMP
Owners: luya
Branches: f18 f19 el6
InitialCC:
Comment 12 Gwyn Ciesla 2013-08-15 08:19:50 EDT
Git done (by process-git-requests).
Comment 13 Fedora Update System 2013-08-15 12:55:41 EDT
gimp-paint-studio-2.0-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gimp-paint-studio-2.0-5.fc19
Comment 14 Fedora Update System 2013-08-15 13:00:35 EDT
gimp-paint-studio-2.0-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gimp-paint-studio-2.0-5.fc18
Comment 15 Fedora Update System 2013-08-15 17:16:25 EDT
gimp-paint-studio-2.0-6.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/gimp-paint-studio-2.0-6.el6
Comment 16 Fedora Update System 2013-08-16 15:50:10 EDT
gimp-paint-studio-2.0-6.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 17 Fedora Update System 2013-08-24 18:28:04 EDT
gimp-paint-studio-2.0-6.fc18 has been pushed to the Fedora 18 stable repository.
Comment 18 Fedora Update System 2013-08-24 18:28:13 EDT
gimp-paint-studio-2.0-6.fc19 has been pushed to the Fedora 19 stable repository.
Comment 19 Fedora Update System 2013-10-03 13:38:57 EDT
gimp-paint-studio-2.0-6.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.