Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-goki-freetype.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-goki-freetype-0-0.1.20210130gitfa8a33a.fc34.src.rpm Description: The Freetype font rasterizer in the Go programming language. Fedora Account System Username: eclipseo
The gcc issue is a false positive, gcc is not required to build the package. APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "FreeType License", "GNU General Public License, Version 2". 38 files have unknown license. Detailed output of licensecheck in /home/rpmbuild/reviews/1922797-golang-github-goki- freetype/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com(golang-github-peterbourgon-diskv- devel, golang-github-opentracing-basictracer-devel, golang-github- hashicorp-retryablehttp-devel, golang-github-bradfitz-smtpd-devel, [...] golang-github-gophercloud-utils-devel, golang-github-aalpar-deheap- devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 11 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-goki-freetype-devel-0-0.1.20210130gitfa8a33a.fc35.noarch.rpm golang-github-goki-freetype-0-0.1.20210130gitfa8a33a.fc35.src.rpm golang-github-goki-freetype-devel.noarch: W: spelling-error Summary(en_US) rasterizer -> pasteurizer, sterilizer, sterilize golang-github-goki-freetype-devel.noarch: W: spelling-error %description -l en_US rasterizer -> pasteurizer, sterilizer, sterilize golang-github-goki-freetype-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/goki/freetype/.goipath golang-github-goki-freetype.src: W: spelling-error Summary(en_US) rasterizer -> pasteurizer, sterilizer, sterilize golang-github-goki-freetype.src: W: spelling-error %description -l en_US rasterizer -> pasteurizer, sterilizer, sterilize golang-github-goki-freetype.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- golang-github-goki-freetype-devel.noarch: W: spelling-error Summary(en_US) rasterizer -> pasteurizer, sterilizer, sterilize golang-github-goki-freetype-devel.noarch: W: spelling-error %description -l en_US rasterizer -> pasteurizer, sterilizer, sterilize golang-github-goki-freetype-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/goki/freetype/.goipath 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://github.com/goki/freetype/archive/fa8a33aabaff00cee178fe14212e0a308a87ea5d/freetype-fa8a33aabaff00cee178fe14212e0a308a87ea5d.tar.gz : CHECKSUM(SHA256) this package : c21e83b266d5a7da8ed4e452e50039a762998f0d9d5625a75aea62c9f81ea2e5 CHECKSUM(SHA256) upstream package : c21e83b266d5a7da8ed4e452e50039a762998f0d9d5625a75aea62c9f81ea2e5 Requires -------- golang-github-goki-freetype-devel (rpmlib, GLIBC filtered): go-filesystem golang(golang.org/x/image/font) golang(golang.org/x/image/math/fixed) Provides -------- golang-github-goki-freetype-devel: golang(github.com/goki/freetype) golang(github.com/goki/freetype)(commit=fa8a33aabaff00cee178fe14212e0a308a87ea5d) golang(github.com/goki/freetype/raster) golang(github.com/goki/freetype/raster)(commit=fa8a33aabaff00cee178fe14212e0a308a87ea5d) golang(github.com/goki/freetype/truetype) golang(github.com/goki/freetype/truetype)(commit=fa8a33aabaff00cee178fe14212e0a308a87ea5d) golang-github-goki-freetype-devel golang-ipath(github.com/goki/freetype) golang-ipath(github.com/goki/freetype)(commit=fa8a33aabaff00cee178fe14212e0a308a87ea5d) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1922797 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, Ocaml, SugarActivity, Java, fonts, R, Python, PHP, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-goki-freetype
FEDORA-2021-a2ddb68436 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a2ddb68436
FEDORA-2021-a3cd7819cc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a3cd7819cc
FEDORA-2021-a3cd7819cc has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a3cd7819cc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a3cd7819cc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-a2ddb68436 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a2ddb68436 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a2ddb68436 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-a2ddb68436 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-a3cd7819cc has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.