Bug 1271954 (hamcrest/hamcrest-php) - Review Request: php-hamcrest - PHP port of Hamcrest Matchers
Summary: Review Request: php-hamcrest - PHP port of Hamcrest Matchers
Keywords:
Status: CLOSED ERRATA
Alias: hamcrest/hamcrest-php
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1062888 1119446
TreeView+ depends on / blocked
 
Reported: 2015-10-15 07:20 UTC by Remi Collet
Modified: 2015-11-27 06:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-16 23:24:26 UTC
Type: ---
Embargoed:
shawn: fedora-review+


Attachments (Terms of Use)
phpcompatinfo-full.log (36.54 KB, text/plain)
2015-11-02 20:26 UTC, Shawn Iwinski
no flags Details
phpcompatinfo-lib.log (24.30 KB, text/plain)
2015-11-02 20:27 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (6.57 KB, text/plain)
2015-11-02 20:27 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2015-10-15 07:20:13 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/20298e564a11ce9fbe5f5ed5e308c2d672f57a62/php/php-hamcrest/php-hamcrest.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-hamcrest-1.2.2-1.remi.src.rpm
Description: 
Hamcrest is a matching library originally written for Java,
but subsequently ported to many other languages.

php-hamcrest is the official PHP port of Hamcrest and essentially follows
a literal translation of the original Java API for Hamcrest,
with a few Exceptions, mostly down to PHP language barriers.

To use this library, you just have to add, in your project:
  require_once '/usr/share/php/Hamcrest/autoload.php';

Fedora Account System Username: remi

Comment 1 Shawn Iwinski 2015-11-02 20:26:57 UTC
Created attachment 1088713 [details]
phpcompatinfo-full.log

phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:58:20 CEST

Comment 2 Shawn Iwinski 2015-11-02 20:27:18 UTC
Created attachment 1088714 [details]
phpcompatinfo-lib.log

phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:58:20 CEST

Comment 3 Shawn Iwinski 2015-11-02 20:27:43 UTC
Created attachment 1088715 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1271954
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Shawn Iwinski 2015-11-02 20:33:39 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required



No blockers.

===== APPROVED =====

Comment 5 Remi Collet 2015-11-03 05:10:51 UTC
Thanks for the review.
SCM request open on pkgdb2

Comment 6 Gwyn Ciesla 2015-11-05 00:53:44 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-hamcrest

Comment 7 Fedora Update System 2015-11-05 08:02:56 UTC
php-hamcrest-1.2.2-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-921e8b56f5

Comment 8 Fedora Update System 2015-11-05 08:03:02 UTC
php-hamcrest-1.2.2-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-ded644582e

Comment 9 Fedora Update System 2015-11-05 08:03:02 UTC
php-hamcrest-1.2.2-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c146a81b1

Comment 10 Remi Collet 2015-11-05 09:21:37 UTC
Built and available in buildroot.
Closing to unblock other bugs.

Comment 11 Fedora Update System 2015-11-06 00:51:37 UTC
php-hamcrest-1.2.2-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-hamcrest'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c146a81b1

Comment 12 Fedora Update System 2015-11-06 02:35:31 UTC
php-hamcrest-1.2.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-hamcrest'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-532291cc10

Comment 13 Fedora Update System 2015-11-07 03:20:20 UTC
php-hamcrest-1.2.2-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update php-hamcrest'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-921e8b56f5

Comment 14 Fedora Update System 2015-11-07 03:20:41 UTC
php-hamcrest-1.2.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update php-hamcrest'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-ded644582e

Comment 15 Fedora Update System 2015-11-16 23:24:24 UTC
php-hamcrest-1.2.2-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-11-17 11:58:53 UTC
php-hamcrest-1.2.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-11-27 05:25:19 UTC
php-hamcrest-1.2.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2015-11-27 06:51:37 UTC
php-hamcrest-1.2.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.