Bug 530342 (kcm-gtk) - Review Request: kcm-gtk - Configure the appearance of GTK apps in KDE
Summary: Review Request: kcm-gtk - Configure the appearance of GTK apps in KDE
Keywords:
Status: CLOSED ERRATA
Alias: kcm-gtk
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-22 12:56 UTC by Rex Dieter
Modified: 2011-07-13 03:14 UTC (History)
4 users (show)

Fixed In Version: 0.5.3-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-11-04 12:19:45 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2009-10-22 12:56:06 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kcm-gtk/kcm-gtk.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kcm-gtk/kcm-gtk-0.5.1-1.fc12.src.rpm
Description:
This is a System Settings configuration module for configuring the
appearance of GTK apps in KDE.

This is intended to Obsolete qtk-qt-engine (for F-12+)

Comment 1 Rex Dieter 2009-10-22 12:58:39 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1762877

rpmlint *.rpm x86_64/*.rpm
kcm-gtk.x86_64: W: obsolete-not-provided gtk-qt-engine
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Comment 2 Jaroslav Reznik 2009-10-22 13:29:18 UTC
Package name OK
Summary OK
License OK
URL & Sources OK
Sources MD5 OK (adc2d8dd60aa74a744a89860b903b0b0)
Buildroot OK
Requires OK
Description OK
File attributes OK
Documentation installed OK
Desktop file OK (KDE service desktop file, no need for validation)
Changelog OK

Rpmlint
SPEC & SRPM OK
RPMS OK (package obsoletes another package which provides gtk-qt-engine)

Builds 
Scratch OK
Local OK

Functionality
Obsoletes gtk-qt-engine OK
Works as described OK

Fixme:
KDE SIG best practices recommends using %{?_kde4_macros_api:Requires: kde4-macros(api) = %{_kde4_macros_api} }

Comment 3 Rex Dieter 2009-10-22 13:37:26 UTC
%changelog
* Thu Oct 22 2009 Rex Dieter <rdieter> 0.5.1-2
- Requires: kde4-macros(api)...

Spec URL: http://rdieter.fedorapeople.org/rpms/kcm-gtk/kcm-gtk.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kcm-gtk/kcm-gtk-0.5.1-2.fc12.src.rpm

Comment 4 Jaroslav Reznik 2009-10-22 14:21:27 UTC
APPROVED

Comment 5 Rex Dieter 2009-10-22 14:24:27 UTC
New Package CVS Request
=======================
Package Name:  kcm-gtk
Short Description: Configure the appearance of GTK apps in KDE
Owners: rdieter
Branches: F-11 F-12
InitialCC:

Comment 6 Kevin Fenzi 2009-10-26 20:06:11 UTC
cvs done.

Comment 7 Fedora Update System 2009-10-29 12:10:23 UTC
kcm-gtk-0.5.1-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/kcm-gtk-0.5.1-2.fc11

Comment 8 Fedora Update System 2009-11-04 12:19:36 UTC
kcm-gtk-0.5.3-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 nucleo 2011-07-12 19:37:14 UTC
Package Change Request
======================
Package Name: kcm-gtk
New Branches: el6
Owners: rdieter nucleo

Comment 10 Gwyn Ciesla 2011-07-13 03:14:50 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.