Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server-15.08.0-1.spec SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server-15.08.0-1.fc22.src.rpm Description: PIM Storage Service Fedora Account System Username: dvratil
Correct Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server.spec
1) Some files seems to be also under GPLv2+ 2) Use either only %{buildroot} or only $RPM_BUILD_ROOT 3) Invalid URL 4) Shouldn't you use %config for /etc/xdg/akonadi.categories? 5) /etc/xdg/akonadi/mysql-local.conf doesn't seem to exist, is it intentional that you create one in %install section?
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server.spec SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server-15.08.0-2.fc22.src.rpm * Tue Sep 01 2015 Daniel Vrátil <dvratil> - 15.08.0-2 - fix license (temporarily) - use %%{buildroot} everywhere - fix URL - use %%config for akonadi.categories The GPLv2+ license is a defect known to upstream and it has been fixed recently (the files have been relicensed to LGPLv2+). The mysql-local.conf file can act as an override for options in mysql-global.conf.
Looks good now, approved.
New Package SCM Request ======================= Package Name: kf5-akonadi-server Short Description: PIM Storage Service Upstream URL: https://projects.kde.org/projects/kde/pim/akonadi Owners: dvratil group::kde-sig Branches: f22 f23 InitialCC:
Git done (by process-git-requests).