Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem-4.98.0-2.src.rpm Description: This package provides macros.kf5 with RPM macros to be used in all KDE Frameworks packages and also owns some of the directories defined by the macros Fedora Account System Username: dvratil
1. %define framework filesystem Use %global. 2. cp %{_sourcedir}/macros.kf5 %{buildroot}%{_rpmconfigdir}/macros.d I prefer using install -pm644 as it can notly set the permission but also can preserve the timestamp.
Are you sure it can be built successfully? I first saw the SPEC then came up with this question, followed by mock output: Processing files: kf5-filesystem-4.98.0-2.noarch RPM build errors: error: File must begin with "/": %{_kf5_includedir} error: File must begin with "/": %{_kf5_plugindir} error: File must begin with "/": %{_kf5_datadir} File must begin with "/": %{_kf5_includedir} File must begin with "/": %{_kf5_plugindir} File must begin with "/": %{_kf5_datadir}
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem-4.98.0-3.src.rpm Replaced %define by %global and cp by install, fixed build (I had the macros.kf5 file already installed, so it didn't fail for me, sorry for that)
PACKAGE APPROVED.
It was decided on last KDE SIG meeting that we want to split the package to kf5-filesystem and kf5-rpmmacros (and eventually add kf5-settings if we decide we need it in future), so I renamed the base package to "kf5" and updated the request accordingly. Nothing much has changed, but I'd like to ask you for a new review anyway. Thanks and sorry for the trouble :-) Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-4.98.0-4.src.rpm
Should be kf5-rpm-macros. Isn't it?
Good point. I just updated the specfile, didn't bump Release. Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-4.98.0-4.src.rpm
Add missing dots at the end of the %description. Others are perfect.
New Package SCM Request ======================= Package Name: kf5 Short Description: Filesystem ownership and RPM macros for KDE Frameworks 5 packages Owners: dvratil Branches: InitialCC: rdieter jgrulich ltinkl kkofler
Git done (by process-git-requests).
Package pushed and built in Koji for rawhide/F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=6764931
Package Change Request ====================== Package Name: kf5 New Branches: f20 Owners: dvratil rdieter jgrulich ltinkl kkofler