Bug 1427990 (kf5-kirigami2) - Review Request: kf5-kirigami2 - QtQuick plugins to build user interfaces based on the KDE UX guidelines
Summary: Review Request: kf5-kirigami2 - QtQuick plugins to build user interfaces base...
Status: CLOSED ERRATA
Alias: kf5-kirigami2
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christian Dersch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords: Reopened
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2017-03-01 16:23 UTC by Rex Dieter
Modified: 2017-04-01 16:52 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2017-04-01 16:52:27 UTC
lupinix.fedora: fedora-review+


Attachments (Terms of Use)

Description Rex Dieter 2017-03-01 16:23:59 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kirigami/kf5-kirigami2.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kirigami/kf5-kirigami2-2.0.0-1.fc25.src.rpm
Description: QtQuick plugins to build user interfaces based on the KDE UX guidelines
Fedora Account System Username: rdieter

V2 of existing kf5-kirigami package, and parallel-installable.  kirigami2 is required by newer versions of plasma-discover-5.9.x

Comment 1 Rex Dieter 2017-03-01 16:24:35 UTC
Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18126560

Comment 2 Kevin Kofler 2017-03-01 17:27:59 UTC
I think you actually need a Requires on BOTH qt5-qtquickcontrols2%{?_isa} and qt5-qtquickcontrols%{?_isa} (v1), last I checked, Kirigami2 used parts of Qt Quick Controls 1 to provide native theme integration for Qt Quick Controls 2.

Comment 3 Kevin Kofler 2017-03-01 18:21:06 UTC
Some of the Qt Quick Controls dependencies were removed in:
https://cgit.kde.org/kirigami.git/commit/src/controls?id=1b0c1e80e4ea54432cb8c6fa52aa5c1d51a25059
but I still see at least:
https://cgit.kde.org/kirigami.git/tree/src/controls/Label.qml#n22

Comment 4 Christian Dersch 2017-03-03 15:03:19 UTC
Please check the following points:
* comment from Kevin about Requires of the two qt5-qtquickcontrols versions
* there is a GPLv2+ licensed file inside, please check your licensing and ask upstream to include a copy of GPLv2 too



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
     generated". 8 files have unknown license. Detailed output of
     licensecheck in /home/review/1427990-kf5-kirigami2/licensecheck.txt

==> We have GPL files here too:
GPL (v2 or later)
-----------------
kirigami2-2.0.0/src/desktopicon.h 

[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/qt5,
     /usr/lib64/qt5/mkspecs, /usr/lib64/cmake,
     /usr/lib64/qt5/mkspecs/modules
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/lib64/qt5/qml/org/kde(kf5-kirigami, kf5-knewstuff,
     kf5-kdeclarative, kf5-plasma), /usr/lib64/qt5/qml/org(kf5-kirigami,
     kf5-knewstuff, kf5-kdeclarative, kf5-plasma)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
==> No copy of GPLv2 included, please query upstream

[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     kf5-kirigami2-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kf5-kirigami2-2.0.0-1.fc26.x86_64.rpm
          kf5-kirigami2-devel-2.0.0-1.fc26.x86_64.rpm
          kf5-kirigami2-debuginfo-2.0.0-1.fc26.x86_64.rpm
          kf5-kirigami2-2.0.0-1.fc26.src.rpm
kf5-kirigami2.x86_64: W: no-documentation
kf5-kirigami2-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-kirigami2-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (debuginfo)
-------------------
Checking: kf5-kirigami2-debuginfo-2.0.0-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
kf5-kirigami2.x86_64: W: no-documentation
kf5-kirigami2-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-kirigami2-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 3 warnings.



Requires
--------
kf5-kirigami2-debuginfo (rpmlib, GLIBC filtered):

kf5-kirigami2 (rpmlib, GLIBC filtered):
    kf5-filesystem
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.7)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libQt5Quick.so.5()(64bit)
    libQt5Quick.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    qt5-qtquickcontrols2(x86-64)
    rtld(GNU_HASH)

kf5-kirigami2-devel (rpmlib, GLIBC filtered):
    kf5-kirigami2(x86-64)



Provides
--------
kf5-kirigami2-debuginfo:
    kf5-kirigami2-debuginfo
    kf5-kirigami2-debuginfo(x86-64)

kf5-kirigami2:
    kf5-kirigami2
    kf5-kirigami2(x86-64)

kf5-kirigami2-devel:
    cmake(KF5Kirigami2)
    kf5-kirigami2-devel
    kf5-kirigami2-devel(x86-64)



Unversioned so-files
--------------------
kf5-kirigami2: /usr/lib64/qt5/qml/org/kde/kirigami.2/libkirigamiplugin.so

Source checksums
----------------
http://download.kde.org/stable/kirigami/kirigami2-2.0.0.tar.xz :
  CHECKSUM(SHA256) this package     : 499bfcc5080dd65877a67700ff71f84a7b43f0f87b7c72e9f68c7bb92e11a293
  CHECKSUM(SHA256) upstream package : 499bfcc5080dd65877a67700ff71f84a7b43f0f87b7c72e9f68c7bb92e11a293


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1427990
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 5 Rex Dieter 2017-03-03 15:16:26 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kirigami/kf5-kirigami2.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kirigami/kf5-kirigami2-2.0.0-2.fc25.src.rpm

%changelog
* Fri Mar 03 2017 Rex Dieter <rdieter@fedoraproject.org> - 2.0.0-2
- Requires: qt5-qtquickcontrols, License: GPLv2+

Comment 6 Christian Dersch 2017-03-03 15:20:48 UTC
Fine now => Approved!

Comment 7 Gwyn Ciesla 2017-03-06 14:56:43 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-kirigami2

Comment 8 Rex Dieter 2017-03-07 00:53:38 UTC
imported, thanks.

Comment 9 Fedora Update System 2017-03-08 16:09:12 UTC
plasma-discover-5.9.3-2.fc26 kf5-kirigami2-2.0.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1156554295

Comment 10 Fedora Update System 2017-03-10 23:22:08 UTC
kf5-kirigami2-2.0.0-2.fc26, plasma-discover-5.9.3-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1156554295

Comment 11 Fedora Update System 2017-04-01 16:52:27 UTC
kf5-kirigami2-2.0.0-2.fc26, plasma-discover-5.9.3-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.