Spec URL: http://github.com/downloads/matriux/fedora/openmolar.spec
SRPM URL: http://github.com/downloads/matriux/fedora/openmolar-0.1.9-1.fc13.src.rpm
Description: 
Dental Practice Management Suite, using a Mysql database server
to maintain patient records, accounts, and correspondence.

(In reply to comment #0)
> Spec URL: <spec info here>
> SRPM URL: <srpm info here>
> Description: <description here>
> 
> Rpmlint
> ===============
> rpmlint openmolar.spec ../RPMS/noarch/openmolar-0.1.9-1.fc13.noarch.rpm 
> ../SRPMS/openmolar-0.1.9-1.fc13.src.rpm 
> openmolar.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/openmolar/main.py 0644L /usr/bin/env
> openmolar.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/openmolar/settings/_version.py 0644L
> /usr/bin/env
> openmolar.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/openmolar/qt4gui/schema_updater.py 0644L
> /usr/bin/env
> openmolar.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/openmolar/firstRun.py 0644L /usr/bin/env
> openmolar.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/openmolar/createdemodatabase.py 0644L
> /usr/bin/env
> openmolar.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/openmolar/qt4gui/customwidgets/calendars.py
> 0644L /usr/bin/env
> 2 packages and 1 specfiles checked; 6 errors, 0 warnings.
> 
> Which can be ignored
> 
Normally, you can remove shebang from those files to avoid rpmlint errors.
See https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_Python_libraries

+ is ok
- Needs work

Review:
+ package builds in mock (rawhide i686).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2218732

+ rpmlint output for SRPM and for RPM is
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/main.py 0644L /usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/settings/_version.py 0644L
/usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/qt4gui/schema_updater.py 0644L
/usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/firstRun.py 0644L /usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/createdemodatabase.py 0644L
/usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/qt4gui/customwidgets/calendars.py
0644L /usr/bin/env
openmolar.noarch: W: no-manual-page-for-binary openmolar
Each executable in standard binary directories should have a man page.

+ source files match upstream url (sha1sum)
27fff756480eb2072543bf80df8ed2b1d717b08c  openmolar-0.1.9.tar.gz
27fff756480eb2072543bf80df8ed2b1d717b08c  openmolar-0.1.9.tar.gz.srpm
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ Translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ GUI application and Desktop file installed correctly.

Suggestions:
1) If you want either you can ask upstream to include openmolar man page or you
can also write it.
This is not blocker for review but just a suggestion.

2) remove following from %build as there is no compilation happenings that need
RPM_OPT_FLAGS.

CFLAGS="$RPM_OPT_FLAGS" 

3) Add PKG-INFO to %doc

APPROVED.

And If you want to remove shebang which looks not needed, you can use following in %install


for lib in %{buildroot}%{python_sitelib}/%{name}/*.py %{buildroot}%{python_sitelib}/%{name}/settings/_version.py  %{buildroot}%{python_sitelib}/%{name}/qt4gui/*.py %{buildroot}%{python_sitelib}/%{name}/qt4gui/customwidgets/*.py ; do
 sed '/\/usr\/bin\/env/d' $lib > $lib.new &&
 touch -r $lib $lib.new &&
 mv $lib.new $lib
done

Some more comments:

I think you may need add Scriptlet to spec.
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache


Hi Parag,

> 3) Add PKG-INFO to %doc

Should python modules include PKG-INFO to %doc? It seems *.egg-info will copy informations from PKG-INFO, I'm not sure about this.

Thanks Chen,

Ah! howcome my eyes missed this file
-rw-r--r--    1 root    root                    27519 Oct  8  2009 /usr/share/icons/hicolor/scalable/apps/openmolar.svg

Definitely this package should add to spec gtk-update-icon-cache scriptlet. 
I see icon is not appearing in menu. I only tested its functionality using menu.

Regarding PKG-INFO:- you are correct egg-info already includes them so no need to add PKG-INFO as %doc.

Thanks Parag for the review,thanks Chen for the comments.

New upstream release,Version:0.2.0

Updated spec is here

SPEC : http://github.com/downloads/matriux/fedora/openmolar.spec
SRPM : http://github.com/downloads/matriux/fedora/openmolar-0.2.0-1.fc12.src.rpm

New Package CVS Request
=======================
Package Name: openmolar
Short Description: Open Source Dental Practice Management Software
Owners: matriux
Branches: F-12 F-13 F-14
InitialCC: susmit

CVS done (by process-cvs-requests.py).

There is no F-14 branch yet.

Any reason for not building this package yet on koji?

ping

Closing this as no response from submitter.

I shall take this.
Thanks.

I don't have commit access to this.
I have submitted a request
https://admin.fedoraproject.org/pkgdb/acls/name/openmolar

Maybe it is about time to bring this question to the devel mailing-list.

Please submit a new review request for this package. This has been stalled since long time.

Hi Parag,

The package has already been approved. Susmit just hasn't gotten commit access yet. Do we need to re-review this package, or can we just request the right people to approve Susmit's commit access?

Thanks,
Ankur

ah! SCM already done. See http://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers

The packager seems to have several other packager, please start the nonresponsive maintainer process so those get orphaned too.  I've approved your acl requests for this package.  You can set yourself to be the owner if the owner doesn't appear in a reasonable amount of time.

https://admin.fedoraproject.org/pkgdb/users/packages/matriux

Imran, are you still interested in this?
This is first ping in accordance with Non-responsive Maintainer Policy.

Thanks.