Spec URL: http://dvratil.fedorapeople.org/kf5/review/oxygen-fonts.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/oxygen-fonts-0.3.95-1.fc20.src.rpm Description: Oxygen fonts created by the KDE Community Fedora Account System Username: dvratil
1) $ rpmlint *.rpm oxygen-fonts.noarch: W: unexpanded-macro /usr/share/fontconfig/conf.avail/%{fontconf} %{fontconf} oxygen-fonts.noarch: W: unexpanded-macro /etc/fonts/conf.d/%{fontconf} %{fontconf} oxygen-fonts.src: W: file-size-mismatch oxygen-fonts-0.3.95.tar.xz = 533104, http://download.kde.org/unstable/plasma/4.95.0/oxygen-fonts-0.3.95.tar.xz = 533112 oxygen-fonts-devel.noarch: W: only-non-binary-in-usr-lib oxygen-fonts-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 5 warnings. ==> Fix above issues 2) missing following %global fontconf oxygen-fontconfig.conf 3) License is not clear to me. Source font shows embedded license string as OFL 1.1 4) Do we need cmake files installed (or devel package needed)?
Spec URL: http://dvratil.fedorapeople.org/kf5/review/oxygen-fonts.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/oxygen-fonts-0.3.95-2.fc20.src.rpm > 2) missing following > %global fontconf oxygen-fontconfig.conf Fixed > 3) License is not clear to me. Source font shows embedded license string as OFL > 1.1 According to README.md: "The Oxygen Fonts are released under either The SIL Open Font License (OFL) version 1.1 or the GNU General Public License version 3 with font exception (GPL+FE)." - so I updated the package license to "OFL or GPLv3 with exceptions" (but I'm no expert) 4) Do we need cmake files installed (or devel package needed)? Yes, kf5-plasma package (bug 1111970) will refuse to build if oxygen-fonts is not found via CMake. Bit unfortunate, but I guess upstream wants to make sure Oxygen is always used as the default font.
looks good now. I have one more suggestion 1) %clean can be removed as its not needed on Fedora and EPEL6/7 APPROVED.
ah! just realized you have not chosen any priority for fontconfig file. See /etc/fonts/conf.d/README I will suggest you can choose 61 priority. Change spec from %global fontconf oxygen-fontconfig.conf to %global fontconf 61-%{fontname}.conf
Ok, fixed both issues locally in the spec. Thanks for the review.
New Package SCM Request ======================= Package Name: oxygen-fonts Short Description: Oxygen fonts created by the KDE Community Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler than Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: oxygen-fonts New Branches: f20 Owners: dvratil jgrulich ltinkl rdieter kkofler than