Spec URL: http://fedorapeople.org/~iarnell/review/perl-Module-Used.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Module-Used-1.2.0-1.fc12.src.rpm Description: Modules are found statically based upon use and require statements. If use of the base or parent is found, both that module and the referenced ones will be returned. If Moose or Moose::Role are found, this will look for extends and with sugar will be looked for; presently, this will miss modules listed in parentheses. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1328535 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1328535 + rpmlint is silent for SRPM and for RPM. + source files match upstream url ba3421bb8f990f1729b8e2ad7fa233dc Module-Used-v1.2.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=22, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.28 cusr 0.04 csys = 0.35 CPU) + Package perl-Module-Used-1.2.0-1.fc12.noarch => Provides: perl(Module::Used) Requires: /usr/bin/env perl >= 0:5.008003 perl(English) perl(Exporter) perl(File::Next) perl(Module::Used) perl(PPI::Document) perl(Readonly) perl(strict) perl(utf8) perl(version) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Module-Used Short Description: Find modules loaded by Perl code without running it Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Module-Used-1.2.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Module-Used-1.2.0-1.fc11
perl-Module-Used-1.2.0-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Module-Used-1.2.0-1.fc10
Thanks for the review! :-)
perl-Module-Used-1.2.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Module-Used-1.2.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.