Spec URL: http://fedorapeople.org/~iarnell/review/perl-String-Diff.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-String-Diff-0.04-1.fc12.src.rpm Description: String::Diff is the difference of a consecutive string is made. after general diff is done, the difference in the line is searchable. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1326023 *rt-0.07
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1326023 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 440bd85674f8602f18a2ab7978f1fa53 String-Diff-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=12, Tests=132, 2 wallclock secs ( 0.07 usr 0.01 sys + 1.93 cusr 0.10 csys = 2.11 CPU) + Package perl-String-Diff-0.04-1.fc12.noarch => Provides: perl(String::Diff) = 0.04 Requires: perl(base) perl(strict) perl(warnings) Suggestions: 1) remove Requires: perl(Algorithm::Diff) from SPEC. APPROVED.
New Package CVS Request ======================= Package Name: perl-String-Diff Short Description: Simple diff to String Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
perl(Algorithm::Diff) is required but not automatically detected. Will add comment to spec.
cvs done.
perl-String-Diff-0.04-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-String-Diff-0.04-2.fc11
perl-String-Diff-0.04-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-String-Diff-0.04-2.fc10
perl-String-Diff-0.04-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-String-Diff-0.04-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.