Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Debug.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Debug-2.3.1-1.fc18.src.rpm Description: The Debug Component provides tools to ease debugging PHP code. Fedora Account System Username: siwinski
Created attachment 814160 [details] phpci.log phpcompatinfo version 2.24.0.
Created attachment 814161 [details] review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 979793 Buildroot used: fedora-19-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG
Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=6080475 Issues: ======= [!]: Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/extras/SPECS/review/979793-php-symfony2-Debug/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL => minor diff in the package.xml which have obviously be regenerated, not an issue for the review [~]: Package is named according to the Package Naming Guidelines. New Guildelines recommend the use of lowercase names. As all the symfony2 stack use CamelCase, I thinks this could be ignored. [!]: Package consistently uses macros (instead of hard-coded directory names). => only a small comment symfony_{min,max}_ver could be ambiguous, as according to various composer.json, you have not a single minimal version, some could require 2.0, 2.1, 2.2 or 2.3. So a per component version seems clearer. [~]: Package is named according to the Package Naming Guidelines. New Guildelines recommend the use of lowercase names. As all the symfony2 stack use CamelCase, I thinks this could be ignored. [!]: Requires correct, justified where necessary. php-common => php(language) [!]: Latest version is packaged. 2.3.6 available
I just submitted the single-spec php-symfony2 review request (bug 1021749) that I would prefer to move to.
*** This bug has been marked as a duplicate of bug 1021749 ***