Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-breeze.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-breeze-5.1.1-1.fc21.src.rpm Description:Artwork, styles and assets for the Breeze visual style for the Plasma Desktop. Fedora Account System Username: jgrulich Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8410486
Initial comments: (non-blockers) * I think I'd prefer to follow the upstream name here, and stick with just 'breeze', what's the justification to use a plasma- prefix here? * s|%{_qt5_prefix}/qml|%{_kf5_qmldir}|
Renamed to breeze. Fixed macro. Spec URL: https://jgrulich.fedorapeople.org/plasma5/breeze.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/breeze-5.1.1-1.fc21.src.rpm Description:Artwork, styles and assets for the Breeze visual style for the Plasma Desktop. Fedora Account System Username: jgrulich Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8513700
Naming: ok (though some suggestions follow) 1. Sorry, thinking it over, we SHOULD keep the plasma- prefix. We already did set some precedent with plasma-oxygen and should stay consistent. 2. on the topic of consistency and precedent, SHOULD rename breeze-kde4 to kde-style-breeze, but won't consider that a blocker. We (kde-sig) probably ought to discuss how best to handle that moving forward. 3. breeze-icon-theme SHOULD be split out into subpkg (add MUST add proper icon scriptlets) sources: ok 81c324560667424a99beeb0657c02ba5 breeze-5.1.1.tar.xz licensing: ok 4. SHOULD use better project URL, I'd suggest URL: https://projects.kde.org/projects/kde/workspace/breeze 5. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} over %make_install
1. Renamed back 2. Renamed 3. Created subpkg + added missing scriptlets 4. Fixed url 5. Fixed Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-breeze.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-breeze-5.1.1-1.fc21.src.rpm Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8527191
looks good, APPROVED
New Package SCM Request ======================= Package Name: plasma-breeze Short Description: Artwork, styles and assets for the Breeze visual style for the Plasma Desktop Upstream URL: https://projects.kde.org/projects/kde/workspace/breeze Owners: @kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
WARNING: "@kde-sig" is not a valid FAS account.
New Package SCM Request ======================= Package Name: plasma-breeze Short Description: Artwork, styles and assets for the Breeze visual style for the Plasma Desktop Upstream URL: https://projects.kde.org/projects/kde/workspace/breeze Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
WARNING: "group::kde-sig" is not a valid FAS account.
New Package SCM Request ======================= Package Name: plasma-breeze Short Description: Artwork, styles and assets for the Breeze visual style for the Plasma Desktop Upstream URL: https://projects.kde.org/projects/kde/workspace/breeze Owners: rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
Git done (by process-git-requests).