Spec URL: https://ppfeister.fedorapeople.org/python-unix-ar.spec SRPM URL: https://ppfeister.fedorapeople.org/python-unix-ar-0.2.1-1.fc41.src.rpm Description: This packages allows the reading and writing of AR archive files. Fedora Account System Username: ppfeister
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=121830915
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/7948459 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2304068-python-unix-ar/fedora-rawhide-x86_64/07948459-python-unix-ar/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Only issue found is the unpacked LICENSE.txt file which is not tagged as %license. Please fix, otherwise the package is good to go. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Note: BSD-3-Clause [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License". 16 files have unknown license. Detailed output of licensecheck in [X]: Package must own all directories that it creates. [-]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. Note: package using still using inline changelog and not %autochangelog/%autorelease [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. Note: Test run failed [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [-]: Packages must not store files under /srv, /opt or /usr/local Note: Test run failed [X ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. Python: [-]: Binary eggs must be removed in %prep Note: Test run failed [-]: Python eggs must not download any dependencies during the build process. Note: Test run failed [-]: A package which is used by another package via an egg interface should provide egg info. Note: Test run failed [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. |Note: unpacked license file LICENSE.txt [X]: Final provides and requires are sane (see attachments). [X ]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-unix-ar-0.2.1-1.fc42.noarch.rpm python-unix-ar-0.2.1-1.fc42.src.rpm =============================== rpmlint session starts ============================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8ziwevww')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 8 filtered, 15 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/getninjas/unix_ar/archive/0.2.1/unix-ar-0.2.1.tar.gz : CHECKSUM(SHA256) this package : 4e1c6e8fe5255b7babe93b9af51532ba09c6946eee413c5db00cab3878d7ed2f CHECKSUM(SHA256) upstream package : 4e1c6e8fe5255b7babe93b9af51532ba09c6946eee413c5db00cab3878d7ed2f Requires -------- python3-unix-ar (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-unix-ar: python-unix-ar python3-unix-ar python3.13-unix-ar python3.13dist(unix-ar) python3dist(unix-ar) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2304068 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, R, PHP, Haskell, Perl, fonts, C/C++, SugarActivity, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Didn't realize we had two Michaels in that thread. Thanks for the review! That helps us get both updates out ASAP The -l flag on pyproject_save_files __should__ normally include the license automatically, and fail if not found --- it's seen in the package's final file list https://download.copr.fedorainfracloud.org/results/%40fedora-review/fedora-review-2304068-python-unix-ar/fedora-rawhide-x86_64/07948459-python-unix-ar/fedora-review/files.dir HOWEVER, I'm still adding the %license macro as you suggest because it's probably just better that way anyways -- helps avoid issues from popping up down the line. I've added it to the spec.
Good to go. Thank you
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-unix-ar
FEDORA-2024-e7f98c3169 (python-unix-ar-0.2.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e7f98c3169
FEDORA-2024-e7f98c3169 (python-unix-ar-0.2.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.