Spec URL: http://feynman.q-ix.net/rpm/pyxtrlock.spec SRPM URL: http://feynman.q-ix.net/rpm/pyxtrlock-0.2-1.fc19.src.rpm Description: pyxtrlock, like its predecessor xtrlock, is a very minimal X display lock program. While pyxtrlock is running, it does not obscure the screen, only the mouse and keyboard are grabbed and the mouse cursor becomes a padlock. Output displayed by X programs, and windows put up by new X clients, continue to be visible, and any new output is displayed normally. Fedora Account System Username: leonn I’m upstream maintainer of pyxtrlock. This and python3-simplepam (Bug 1065301) are my first packages, so as mentioned there, I’m looking for a sponsor.
One note about the Requires: The package needs libX11, libxcb >= 1.4 and xcb-util-image (libxcb-image.so). I haven’t put these in because all the guidelines tell me not to specify library dependencies, and also rpmlint spews errors if I do. However, they aren’t picked up automatically, as far as I can see (rpm -qRp doesn’t show them). The program uses these libraries through python ctypes, I guess the automatic algorithm can’t find the dependencies in that case? Should I specify them explicitly despite the rpmlint errors, or leave them out?
(In reply to Leon Weber from comment #1) > One note about the Requires: The package needs libX11, libxcb >= 1.4 and > xcb-util-image (libxcb-image.so). I haven’t put these in because all the > guidelines tell me not to specify library dependencies, and also rpmlint > spews errors if I do. > > However, they aren’t picked up automatically, as far as I can see (rpm -qRp > doesn’t show them). The program uses these libraries through python ctypes, > I guess the automatic algorithm can’t find the dependencies in that case? > Should I specify them explicitly despite the rpmlint errors, or leave them > out? Please ignore the rpmlint as RPM can't recognize the dependencies of python packages. For python packages please fulfill the field.
Spec URL: http://feynman.q-ix.net/rpm/pyxtrlock.spec SRPM URL: http://feynman.q-ix.net/rpm/pyxtrlock-0.2-2.fc19.src.rpm Thanks, spec and rpm updated.
sponsored, removing blocker.
Spec URL: http://feynman.q-ix.net/rpm/pyxtrlock.spec SRPM URL: http://feynman.q-ix.net/rpm/pyxtrlock-0.2-3.fc19.src.rpm Added a .desktop file, since I figured a screen lock counts as a GUI application. Also, I’m sponsored now, so I only need a normal review and approval. The dependency is in rawhide and is making its way through F19/F20 testing right now, so there’re no more blockers.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- pyxtrlock-0.2/lib/X.py pyxtrlock-0.2/lib/__init__.py pyxtrlock-0.2/lib/utils.py pyxtrlock-0.2/lib/xcb.py pyxtrlock-0.2/make_default_lock.py pyxtrlock-0.2/setup.py pyxtrlock-0.2/tools/make_lock.py pyxtrlock-0.2/tools/repickle.py [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: pyxtrlock-0.2-3.fc21.noarch.rpm pyxtrlock-0.2-3.fc21.src.rpm pyxtrlock.noarch: E: explicit-lib-dependency libX11 pyxtrlock.noarch: W: spelling-error %description -l en_US xtrlock -> oarlock pyxtrlock.noarch: W: invalid-url URL: https://zombofant.net/hacking/pyxtrlock HTTP Error 405: Method Not Allowed pyxtrlock.noarch: W: no-manual-page-for-binary pyxtrlock pyxtrlock.src: W: spelling-error %description -l en_US xtrlock -> oarlock pyxtrlock.src: W: invalid-url URL: https://zombofant.net/hacking/pyxtrlock HTTP Error 405: Method Not Allowed 2 packages and 0 specfiles checked; 1 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint pyxtrlock pyxtrlock.noarch: E: explicit-lib-dependency libX11 pyxtrlock.noarch: W: spelling-error %description -l en_US xtrlock -> oarlock pyxtrlock.noarch: W: invalid-url URL: https://zombofant.net/hacking/pyxtrlock HTTP Error 405: Method Not Allowed pyxtrlock.noarch: W: no-manual-page-for-binary pyxtrlock 1 packages and 0 specfiles checked; 1 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- pyxtrlock (rpmlib, GLIBC filtered): /usr/bin/python3 libX11 libxcb python(abi) python3-simplepam xcb-util-image Provides -------- pyxtrlock: application() application(pyxtrlock.desktop) pyxtrlock Source checksums ---------------- https://github.com/leonnnn/pyxtrlock/archive/0.2.tar.gz : CHECKSUM(SHA256) this package : f48f54593243ee7b30ffea6d5c6434932e474f2200e3de3b7b80612f50bf0c20 CHECKSUM(SHA256) upstream package : f48f54593243ee7b30ffea6d5c6434932e474f2200e3de3b7b80612f50bf0c20 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn pyxtrlock-0.2-3.fc19.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------- 1. Ignore that rpmlint results, but please add a note around libX11 of the reason BRed, also you can do that for libxcb. 2. ${RPM_BUILD_ROOT} and $RPM_BUILD_ROOT are presented, please eithor use $RPM_BUILD_ROOT or %{buildroot} (If you enjoy brackets) 3. Icon=gnome-lockscreen In order to avoid conflicts in the future, please rename your icon. 4. Do you think this package needs an egg for import? :) 5. Please add license header for: Unknown or generated -------------------- pyxtrlock-0.2/lib/X.py pyxtrlock-0.2/lib/__init__.py pyxtrlock-0.2/lib/utils.py pyxtrlock-0.2/lib/xcb.py pyxtrlock-0.2/make_default_lock.py pyxtrlock-0.2/setup.py pyxtrlock-0.2/tools/make_lock.py pyxtrlock-0.2/tools/repickle.py 6. You can add a manpage when you have time. -------------------- Fix above and attach the new stuffs. Then I will set +. PACKAGE APPROVED.
Thanks for taking a look at the package, Christopher. (In reply to Christopher Meng from comment #6) > 2. ${RPM_BUILD_ROOT} and $RPM_BUILD_ROOT are presented, please eithor use > $RPM_BUILD_ROOT or %{buildroot} (If you enjoy brackets) Whoops :) > 3. Icon=gnome-lockscreen > > In order to avoid conflicts in the future, please rename your icon. I was actually hoping to reuse gnome’s lockscreen icon, but now I’ve decided to create an extra pyxtrlock icon for Fedora. I might also ship it upstream at some point, if I decide to ship the .desktop file as well. > 4. Do you think this package needs an egg for import? :) Good catch. > 5. Please add license header for: > > Unknown or generated > -------------------- > pyxtrlock-0.2/lib/X.py > pyxtrlock-0.2/lib/__init__.py > pyxtrlock-0.2/lib/utils.py > pyxtrlock-0.2/lib/xcb.py > pyxtrlock-0.2/make_default_lock.py > pyxtrlock-0.2/setup.py > pyxtrlock-0.2/tools/make_lock.py > pyxtrlock-0.2/tools/repickle.py Is this really necessary? There’s the COPYING file explicitly stating the license, and I wouldn’t like to divert from upstream here. I might consider adding the headers upstream, but that wouldn’t be before the next release. I’ve fixed the rest for now: Spec URL: http://feynman.q-ix.net/rpm/pyxtrlock.spec SRPM URL: http://feynman.q-ix.net/rpm/pyxtrlock-0.2-4.fc19.src.rpm %changelog * Thu Feb 20 2014 Leon Weber <leon> - 0.2-4 - Add note justifying explicit lib dependencies - Use buildroot macro consistently - Ship pyxtrlock icon - Use mkdir -p without macro - Remove egg file
Writing license header is a good habit, not a must-have. Also forgot this: cp %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/ You Ruthie can add -a option to preserve the timestamp, or use install -pm644 to install it with timestamp preserved and permission correctly set. Your choice here. Finally hope you can ship desktop file and icon in the git repo(tarball). Hint: my internal project use setup.py to install it directly, but I will use desktop-file-validate to validate itself. Your choice again. (I can submit a patch to github if you want)
Writing license header is a good habit, not a must-have. Also forgot this: cp %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/ You also can add -a option to preserve the timestamp, or use install -pm644 to install it with timestamp preserved and permission correctly set. Your choice here. Finally hope you could ship desktop file and icon in the git repo(tarball). Hint: my internal project use setup.py to install it directly, but I will use desktop-file-validate to validate itself. Your choice again. (I can submit a patch to github if you want) Welcome to Fedora.
Ignore comments 8 as it's uncompleted.
(In reply to Christopher Meng from comment #9) > cp %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/ > > You also can add -a option to preserve the timestamp, or use install -pm644 > to install it with timestamp preserved and permission correctly set. Your > choice here. Will fix that on import. > Finally hope you could ship desktop file and icon in the git repo(tarball). I’ll do that upstream before the next release. > Welcome to Fedora. Thanks!
New Package SCM Request ======================= Package Name: pyxtrlock Short Description: The X transparent screen lock rewritten in Python Owners: leonn Branches: f19 f20 InitialCC:
Git done (by process-git-requests).
pyxtrlock-0.2-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pyxtrlock-0.2-5.fc19
pyxtrlock-0.2-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/pyxtrlock-0.2-5.fc20
pyxtrlock-0.2-5.fc20 has been pushed to the Fedora 20 testing repository.
pyxtrlock-0.2-5.fc19 has been pushed to the Fedora 19 stable repository.
pyxtrlock-0.2-5.fc20 has been pushed to the Fedora 20 stable repository.