Spec URL: http://github.com/downloads/matriux/fedora/rktime.spec SRPM URL: http://github.com/downloads/matriux/fedora/rktime-0.6-1.fc11.src.rpm Description: rktime is a command-line utility which displays the time in multiple timezones in an easy-to-read way, using color to help indicate which locations are currently in business hours. Rpmlint ========= [imran@localhost SPECS]$ rpmlint rktime.spec ../SRPMS/rktime-0.6-1.fc11.src.rpm ../RPMS/noarch/rktime-0.6-1.fc11.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
1) I don't think you need to write Requires: sh-utils as its very core package and you will find it already installed on your system. 2) Correct the macro style usage. See https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS And See https://fedoraproject.org/wiki/Packaging:RPMMacros 3) License should be GPLv2
Updated Spec and Src Rpm SPEC URL:http://github.com/downloads/matriux/fedora/rktime.spec SRPMS URL:http://github.com/downloads/matriux/fedora/rktime-0.6-2.fc11.src.rpm
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2157338 + rpmlint is silent for SRPM and for RPM. rktime.src: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti rktime.src: W: spelling-error %description -l en_US timezones -> timezone, time zones, time-zones rktime.noarch: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti rktime.noarch: W: spelling-error %description -l en_US timezones -> timezone, time zones, time-zones 2 packages and 0 specfiles checked; 0 errors, 4 warnings. ==> Ignore these messages. + source files match upstream url (sha1sum) 78e26fd538872ea11b4cf610016128ae0c934d4e rktime-0.6.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED.
I see you have done good reviews. So I am going to sponsor you now and therefore removing FE-NEEDSPONSOR.
Thanks New Package CVS Request ======================= Package Name: dnsenum Short Description: A tool to enumerate DNS info about domains Owners: matriux Branches: F-12 F-13 InitialCC:
New Package CVS Request ======================= Package Name: rktime Short Description: Multi-zone time display utility Owners: matriux Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
I think this package is already built for requested branches. Any reason for not closing this review?
Hi Parag, Closing it now,thanks