Spec URL: https://dridi.fedorapeople.org/review/vmod-querystring.spec SRPM URL: https://dridi.fedorapeople.org/review/vmod-querystring-1.0.1-1.fc24.src.rpm Description: The purpose of this module is to give you a fine-grained control over a URL's query-string in Varnish Cache. It's possible to remove the query-string, clean it, sort its parameters or filter it to only keep a subset of them. This can greatly improve your hit ratio and efficiency with Varnish, because by default two URLs with the same path but different query-strings are also different. This is what the RFCs mandate but probably not what you usually want for your web site or application. A query-string is just a character string starting after a question mark in a URL. But in a web context, it is usually a structured key/values store encoded with the `application/x-www-form-urlencoded' media type. This module deals with this kind of query-strings. Fedora Account System Username: dridi
This review request supersedes 953514 and builds on packaging progress made in Varnish 4.0 and later 5.0. Instead of requiring a whole Varnish source tree as it was the case when the module was building against 3.0, it now relies on packaging goodies from Varnish 5 and builds against at least Varnish 4.1.3 (f24). Scratch builds available for: - rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=15796556 - f24 http://koji.fedoraproject.org/koji/taskinfo?taskID=15796561
Please see detailed comments below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1379174-vmod- querystring/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ---> Source tarball should be the same as upstream. Please see checksums below. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ---> No license installed. Source tarball includes license file. Please use %license macro to install license. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1379174 -vmod-querystring/licensecheck.txt GPL (v3 or later) ----------------- vmod-querystring-1.0.1/LICENSE vmod-querystring-1.0.1/debian/copyright vmod-querystring-1.0.1/src/vmod_querystring.c MIT/X11 (BSD like) ------------------ vmod-querystring-1.0.1/build-aux/install-sh Unknown or generated -------------------- vmod-querystring-1.0.1/CHANGELOG vmod-querystring-1.0.1/CONTRIBUTORS vmod-querystring-1.0.1/build-aux/ar-lib vmod-querystring-1.0.1/build-aux/compile vmod-querystring-1.0.1/build-aux/depcomp vmod-querystring-1.0.1/build-aux/ltmain.sh vmod-querystring-1.0.1/build-aux/missing vmod-querystring-1.0.1/build-aux/test-driver vmod-querystring-1.0.1/configure vmod-querystring-1.0.1/debian/changelog vmod-querystring-1.0.1/debian/compat vmod-querystring-1.0.1/debian/control vmod-querystring-1.0.1/debian/rules vmod-querystring-1.0.1/debian/source/format ---> GPLv3+ is correct license for installed binary. GPL (v3 or later) ----------------- vmod-querystring-1.0.1/LICENSE vmod-querystring-1.0.1/debian/copyright vmod-querystring-1.0.1/src/vmod_querystring.c MIT/X11 (BSD like) ------------------ vmod-querystring-1.0.1/build-aux/install-sh Unknown or generated -------------------- vmod-querystring-1.0.1/CHANGELOG vmod-querystring-1.0.1/CONTRIBUTORS vmod-querystring-1.0.1/build-aux/ar-lib vmod-querystring-1.0.1/build-aux/compile vmod-querystring-1.0.1/build-aux/depcomp vmod-querystring-1.0.1/build-aux/ltmain.sh vmod-querystring-1.0.1/build-aux/missing vmod-querystring-1.0.1/build-aux/test-driver vmod-querystring-1.0.1/configure vmod-querystring-1.0.1/debian/changelog vmod-querystring-1.0.1/debian/compat vmod-querystring-1.0.1/debian/control vmod-querystring-1.0.1/debian/rules vmod-querystring-1.0.1/debian/source/format These files can be ignored. [!]: License file installed when any subpackage combination is installed. ---> This needs to be fixed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vmod- querystring-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vmod-querystring-1.0.1-1.fc26.x86_64.rpm vmod-querystring-debuginfo-1.0.1-1.fc26.x86_64.rpm vmod-querystring-1.0.1-1.fc26.src.rpm vmod-querystring.x86_64: W: spelling-error %description -l en_US www -> WWW, wow vmod-querystring.x86_64: W: spelling-error %description -l en_US urlencoded -> encoded vmod-querystring.src: W: spelling-error %description -l en_US www -> WWW, wow vmod-querystring.src: W: spelling-error %description -l en_US urlencoded -> encoded 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: vmod-querystring-debuginfo-1.0.1-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- vmod-querystring.x86_64: W: spelling-error %description -l en_US www -> WWW, wow vmod-querystring.x86_64: W: spelling-error %description -l en_US urlencoded -> encoded 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- vmod-querystring-debuginfo (rpmlib, GLIBC filtered): vmod-querystring (rpmlib, GLIBC filtered): libc.so.6()(64bit) libvarnishapi.so.1()(64bit) libvarnishapi.so.1(LIBVARNISHAPI_1.5)(64bit) rtld(GNU_HASH) varnish Provides -------- vmod-querystring-debuginfo: vmod-querystring-debuginfo vmod-querystring-debuginfo(x86-64) vmod-querystring: libvmod_querystring.so()(64bit) vmod-querystring vmod-querystring(x86-64) Unversioned so-files -------------------- vmod-querystring: /usr/lib64/varnish/vmods/libvmod_querystring.so Source checksums ---------------- https://github.com/dridi/libvmod-querystring/releases/download/v1.0.1/vmod-querystring-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 4453f0e007a25e5d55f5241ef523f70706daa472df01f60a4877305dd0af7f71 CHECKSUM(SHA256) upstream package : 0d349155dca5cfb53ccb1284e5d1ba48996485255d74b056b6679c3246819dde diff -r also reports differences ---> This needs to be fixed. Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1379174 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Spec URL: https://dridi.fedorapeople.org/review/vmod-querystring.spec SRPM URL: https://dridi.fedorapeople.org/review/vmod-querystring-1.0.1-1.fc24.src.rpm I added the %license and also added the %optflags since varnish modules are supposed to be loaded by a long-running daemon. Thanks for reviewing!
Thanks for the fixes. These changes look fine. Package approved.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/vmod-querystring
vmod-querystring-1.0.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b4b39da465
vmod-querystring-1.0.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-75ddb4ed26
vmod-querystring-1.0.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-75ddb4ed26
vmod-querystring-1.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b4b39da465
vmod-querystring-1.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
vmod-querystring-1.0.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.