Spec URL: <http://fab.fedorapeople.org/packages/SRPMS/weplab.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/weplab-0.1.5-1.fc9.src.rpm Description: WepLab is a tool designed to teach how WEP works, what different vulnerabilities it has, and how they can be used in practice to break a WEP protected wireless network. So far, WepLab is more than a Wep Key Cracker, it is a Wep Security Analyzer designed from an educational point of view. The author has tried to leave the source code as clear as possible, running away from optimizations that would obfuscate it. This is my first package for Fedora.
Some quick comments on your spec: - license is GPLv2+. Take a look at the haeders of the source: "or (at your option) any later version" - remove INSTALL from %doc, it generic information that is not needed when installed from rpm - remove NEWS from %doc, it's empty - the manpage should not have %doc - mockbuild fails: checking for pcap_open_live in -lpcap... no ERROR: You need libpcap-dev! So obviously this BuildRequires: libpcap-devel
(In reply to comment #1) Thanks for reviewing my first package. > Some quick comments on your spec: > > - license is GPLv2+. Take a look at the haeders of the source: "or (at your > option) any later version" fixed > - remove INSTALL from %doc, it generic information that is not needed when > installed from rpm fixed > - remove NEWS from %doc, it's empty fixed > - the manpage should not have %doc fixed > - mockbuild fails: > checking for pcap_open_live in -lpcap... no > ERROR: You need libpcap-dev! > So obviously this BuildRequires: libpcap-devel fixed -> BuildRequires: libpcap-devel New files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/weplab.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/weplab-0.1.5-2.fc9.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=817120
MD5Sums: 713870965447b0b8b7341409968846fb weplab-0.1.5.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Valid license tag * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Files have appropriate permissions and owners (except the noted item below) * Package installs and uninstalls cleanly * rpmlint produces no errors or warnings +1 APPROVE. Go ahead and request membership to the packager group in the accounts system, and I'll be your sponsor. https://admin.fedoraproject.org/accounts/
Sorry, I was not fast enough (In reply to comment #4) > > Go ahead and request membership to the packager group in the accounts system, > and I'll be your sponsor. Brian, I can also sponsor Fabian if you like. We know each other from real live and we speak the same language. What do you think?
After looking at the README I think this package should require wireless-tools.
(In reply to comment #5) > Brian, I can also sponsor Fabian if you like. We know each other from real live > and we speak the same language. What do you think? I've no problem with that.
(In reply to comment #6) > After looking at the README I think this package should require wireless-tools. hmmm, I guess it's possible to use weplab without the wireless-tools. But this make only sense if the user wants to use it with data from another source (e. g. wireshark, tcpdump, ...). add Requires: wireless-tools New files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/weplab.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/weplab-0.1.5-3.fc9.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=820605
(In reply to comment #8) > add Requires: wireless-tools The decision to add the requirement for wireless-tools is up to you. No need to make another release or do a scratch build for this, because the package was already approved. I have sponsored you, so it's time for the CVSAdmin procedure now: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
New Package CVS Request ======================= Package Name: weplab Short Description: Analyzing WEP encryption security on wireless networks Owners: fab Branches: F-8 F-9
cvs done
Thanks for reviewing, the help, and CVS.
Fabian, I see you have build weplab for F8 and F9, but I don't see it in the repos. Have you made updates in the update system at https://admin.fedoraproject.org/updates ?
Ok, forget about it. I see you pushed them to stable today. Sorry for the noise ;(
weplab-0.1.5-3.fc10 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/weplab-0.1.5-3.fc10
Package Change Request ====================== Package Name: weplab New Branches: el6 epel7 Owners: fab InitialCC:
Git done (by process-git-requests).