Bug 1104592

Summary:	heal info may give Success instead of transport end point not connected when a brick is down.
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.5.1beta2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-24 11:05:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1071800

Description Pranith Kumar K 2014-06-04 09:23:51 UTC

Description of problem:
errno can be over written if another syscall is performed. glfsh_print_pending_heals function in glfs-heal.c suffers from that. We need to change the interface to fix that.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-06-04 09:55:33 UTC

REVIEW: http://review.gluster.org/7965 (heal: Don't depend on errno for reporting heal info status) posted (#2) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-06-04 14:26:14 UTC

REVIEW: http://review.gluster.org/7965 (heal: Don't depend on errno for reporting heal info status) posted (#3) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2014-06-07 15:01:22 UTC

COMMIT: http://review.gluster.org/7965 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit cf8029c55f3efc80b17b2ce3442864643e2fe917
Author: Pranith Kumar K <pkarampu>
Date:   Tue Jun 3 16:50:33 2014 +0530

    heal: Don't depend on errno for reporting heal info status
    
    Change the interfaces to return errno in 'return value'
    to prevent errno being over-written in glfsh_print_brick_from_xl.
    
    Change-Id: I425c85e496a885ed3cd0aeef86d4616aa21bb1b5
    BUG: 1104592
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/7965
    Reviewed-by: Ravishankar N <ravishankar>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Niels de Vos 2014-06-10 16:52:05 UTC

The second (and last?) Beta for GlusterFS 3.5.1 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.1beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040547.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-06-24 11:05:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.1, please reopen this bug report.

glusterfs-3.5.1 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040723.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user