Bug 1157457

Summary:	Bad /etc/logrotate.d file installed by glusterfs
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	logging	Assignee:	bugs <bugs>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-27 10:15:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1157160

Description Niels de Vos 2014-10-27 09:54:10 UTC

+++ This bug was initially created as a clone of Bug #1157160 +++
+++ Bug #1157160 was filed for the Fedora packages, use this  +++
+++ bug to post patches to the GlusterFS Gerrit instance.     +++
+++                                                           +++
+++ Once this bug has been closed, the Fedora package bug     +++
+++ should get closed as well.                                +++

Description of problem:

The glusterfs package installs an /etc/logrotate.d file that changes the global logrotate configuration that impacts all log files systemwide, not just glusterfs's.

Version-Release number of selected component (if applicable):

glusterfs-3.5.2-1.fc20

How reproducible:

Always

Steps to Reproduce:
1. Install Fedora without glusterfs or any other package that pulls in glusterfs, like libvirt/qemu, etc...
2. After a month, or so, observe that various log files are rotated out after four log rotation intervals
3. Install glusterfs, or any package that pulls in glusterfs

Actual results:

Suddenly, all system log files will now be rotated out after 52 log rotation intervals. /var/log won't be purged for at least a year, now.

Expected results:

Installing glusterfs should not affact any other packages' log rotation policies.

Additional info:

The "rotate 52" directive in /etc/logrotate.d/glusterfs-georep, and the other four directives in that file, take effect globally. They apply not only to the log files listed in this specific logrotate configuration file, but to all logrotate files.

Those four directives need to be manually moved inside each individually config file entry, in this file.

Comment 1 Niels de Vos 2014-10-27 09:56:34 UTC

There should not be any global configuration options in the logrotate configuration files that GlusterFS ships. These files need to be modified:

- extras/glusterfs-logrotate
- extras/glusterfs-georep-logrotate

Please make sure to remove the global options from the files, and place them inside each specific log-definition.

Comment 2 Niels de Vos 2014-10-27 10:15:19 UTC


*** This bug has been marked as a duplicate of bug 1126802 ***