Bug 1160710

Summary:	libgfapi: use versioned symbols in libgfapi.so for compatibility
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	libgfapi	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	bugs, gluster-bugs, sdharane
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1160709
Clones:	1165129 (view as bug list)		Environment:
Last Closed:	2014-11-10 15:14:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1160709, 1160711, 1160712
Bug Blocks:	1159253, 1163723, 1165129

Description Kaleb KEITHLEY 2014-11-05 13:14:02 UTC

+++ This bug was initially created as a clone of Bug #1160709 +++

Description of problem:

Bumping the SO_NAME to 7.0.0 breaks compatibility for dependent applications linked against earlier versions of libgfapi.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-11-05 13:50:09 UTC

REVIEW: http://review.gluster.org/9054 (api: versioned symbols in libgfapi.so for compatibility) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Anand Avati 2014-11-05 15:28:52 UTC

REVIEW: http://review.gluster.org/9055 (api: versioned symbols in libgfapi.so for compatibility) posted (#1) for review on release-3.6 by Kaleb KEITHLEY (kkeithle)

Comment 3 Anand Avati 2014-11-05 17:58:01 UTC

REVIEW: http://review.gluster.org/9055 (api: versioned symbols in libgfapi.so for compatibility) posted (#2) for review on release-3.6 by Kaleb KEITHLEY (kkeithle)

Comment 4 Anand Avati 2014-11-07 10:18:01 UTC

COMMIT: http://review.gluster.org/9055 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit 1ffdf112f707a13c9fd74bbf17f99d28f84f0f0c
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Wed Nov 5 10:26:46 2014 -0500

    api: versioned symbols in libgfapi.so for compatibility
    
    Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0
    
    Some nits uncovered:
    
    + there are a couple functions declared that do not have an
      associated definition, e.g. glfs_truncate(), glfs_caller_specific_init()
    
    + there are seven private/internal functions used by heal/src/glfsheal
      and the gfapi master xlator (glfs-master.c): glfs_loc_touchup(),
      glfs_active_subvol(), and glfs_subvol_done(), glfs_init_done(),
      glfs_resolve_at(), glfs_free_from_ctx(), and glfs_new_from_ctx();
      which are not declared in glfs.h;
    
    + for this initial pass at versioned symbols, we use the earliest version
      of all public symbols, i.e. those for which there are declarations in
      glfs.h or glfs-handles.h.
      Further investigation as we do backports to 3.6, 3.4, and 3.4
      will be required to determine if older implementations need to
      be preserved (forward ported) and their associated alias(es) and
      symbol version(s) defined.
    
    FWIW, we should consider linking all of our libraries with a map, it'll
    result in a cleaner ABI. Perhaps something for an intern to do or a
    Google Summer of Code project.
    
    Change-Id: Ie3323e62bb125a3b26214153278b4e998804de0e
    BUG: 1160710
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/9055
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Niels de Vos 2014-11-10 15:14:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users