Bug 1161621
| Summary: | Possible file corruption on dispersed volumes | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Xavi Hernandez <jahernan> | |
| Component: | disperse | Assignee: | Xavi Hernandez <jahernan> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | urgent | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | bugs, gluster-bugs | |
| Target Milestone: | --- | Keywords: | Triaged | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.7.0 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1161885 (view as bug list) | Environment: | ||
| Last Closed: | 2015-05-14 17:28:23 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1161885 | |||
|
Description
Xavi Hernandez
2014-11-07 13:54:59 UTC
REVIEW: http://review.gluster.org/9079 (ec: Remove O_APPEND from flags on create and open.) posted (#1) for review on master by Xavier Hernandez (xhernandez) The problem was caused by files opened with O_APPEND flag. This caused bricks to write on wrong offsets, corrupting the file. The fix solves the problem. REVIEW: http://review.gluster.org/9079 (ec: Remove O_APPEND from flags on create and open.) posted (#2) for review on master by Xavier Hernandez (xhernandez) REVIEW: http://review.gluster.org/9079 (ec: Remove O_APPEND from flags on create and open.) posted (#3) for review on master by Xavier Hernandez (xhernandez) REVIEW: http://review.gluster.org/9079 (ec: Remove O_APPEND from flags on create and open.) posted (#4) for review on master by Xavier Hernandez (xhernandez) REVIEW: http://review.gluster.org/9079 (ec: Remove O_APPEND from flags on create and open.) posted (#5) for review on master by Xavier Hernandez (xhernandez) COMMIT: http://review.gluster.org/9079 committed in master by Vijay Bellur (vbellur) ------ commit eaf7164ff824ad4d69cf225e49c54fc473b300b8 Author: Xavier Hernandez <xhernandez> Date: Sat Nov 8 21:07:09 2014 +0100 ec: Remove O_APPEND from flags on create and open. Allowing O_APPEND flag to pass through to the brick files corrupts fragment contents because writes are not stored on the desired place. Write fop has been modified so that it uses current file size as its write offset. This guarantees that all writes, even those comming from different file descriptors and clients, will write to the end of the file. Change-Id: I9f721f12217a98231fe52e344166d1c94172c272 BUG: 1161621 Signed-off-by: Xavier Hernandez <xhernandez> Reviewed-on: http://review.gluster.org/9079 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Dan Lambright <dlambrig> Reviewed-by: Vijay Bellur <vbellur> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |