Bug 1170959

Summary:	EC_MAX_NODES is defined incorrectly
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.1	CC:	bugs, gluster-bugs, rabhat, wf_cs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1167419	Environment:
Last Closed:	2015-01-28 14:26:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1167419
Bug Blocks:	1163723

Description Xavi Hernandez 2014-12-05 08:26:20 UTC

+++ This bug was initially created as a clone of Bug #1167419 +++

Description of problem:

The macro is defined in ec.c file as the following statement.

#define EC_MAX_NODES    (EC_MAX_FRAGMENTS + ((EC_MAX_FRAGMENTS - 1) / 2))

However the number of the redundancy should be less than the number of fragment, instead of half of it.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-11-25 09:57:26 CET ---

REVIEW: http://review.gluster.org/9193 (ec: Fix incorrect value of EC_MAX_NODES) posted (#1) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2014-12-04 20:35:23 CET ---

COMMIT: http://review.gluster.org/9193 committed in master by Vijay Bellur (vbellur) 
------
commit ca2a3949715fb25862d1e34f9e65283287faa842
Author: Xavier Hernandez <xhernandez>
Date:   Tue Nov 25 09:54:29 2014 +0100

    ec: Fix incorrect value of EC_MAX_NODES
    
    EC_MAX_NODES was incorrectly calculated. Now the value if computed
    as the minimum between the theoretical maximum and the limit imposed
    by the Galois Field.
    
    Change-Id: I75a8345147f344f051923d66be2c10d405370c7b
    BUG: 1167419
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9193
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 1 Anand Avati 2014-12-05 08:28:49 UTC

REVIEW: http://review.gluster.org/9245 (ec: Fix incorrect value of EC_MAX_NODES) posted (#1) for review on release-3.6 by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2014-12-18 12:23:19 UTC

COMMIT: http://review.gluster.org/9245 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit ad16db31df793d90a40fbfced82cae1c86d94658
Author: Xavier Hernandez <xhernandez>
Date:   Tue Nov 25 09:54:29 2014 +0100

    ec: Fix incorrect value of EC_MAX_NODES
    
    EC_MAX_NODES was incorrectly calculated. Now the value if computed
    as the minimum between the theoretical maximum and the limit imposed
    by the Galois Field.
    
    This is a backport of http://review.gluster.org/9193/
    
    Change-Id: I75a8345147f344f051923d66be2c10d405370c7b
    BUG: 1170959
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9245
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Tested-by: Raghavendra Bhat <raghavendra>

Comment 3 Raghavendra Bhat 2015-02-11 09:12:04 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.2, please reopen this bug report.

glusterfs-3.6.2 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.6.2.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978
[2] http://news.gmane.org/gmane.comp.file-systems.gluster.user
[3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137