Bug 1174639

Summary: [SNAPSHOT]: Need logging correction during the lookup failure case.
Product: [Community] GlusterFS Reporter: Raghavendra Bhat <rabhat>
Component: snapshotAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.6.1CC: bugs, nsathyan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-v3.6.2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1146479 Environment:
Last Closed: 2016-02-04 15:05:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1146479    
Bug Blocks: 1163723    

Description Raghavendra Bhat 2014-12-16 08:38:44 UTC
+++ This bug was initially created as a clone of Bug #1146479 +++

Description of problem:
When a lookup is issued, and if the entry is not found then snapview-client
will log failure stating that "Lookup on normal graph failed with error Stale file handle". The failure is not in normal graph, hence it requires modification.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. create a gluster volume
2. mount the volume with fuse mount
3. "cd" into ".snaps" directory
4. mkdir "snap999" (assuming snapshot with snapname "snap999" is not present)
5. check the fuse logs

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-09-25 07:20:13 EDT ---

REVIEW: http://review.gluster.org/8851 (USS : Decide the log entry based on the type of graph.) posted (#1) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-09-29 11:13:45 EDT ---

COMMIT: http://review.gluster.org/8851 committed in master by Vijay Bellur (vbellur) 
------
commit 2736421b26ef03724297b62b4f07ad847c135709
Author: Sachin Pandit <spandit>
Date:   Thu Sep 25 08:32:52 2014 +0530

    USS : Decide the log entry based on the type of graph.
    
    Problem : When a lookup is issued, and if the entry is not found
    then snapview-client will log failure stating that
    "Lookup on normal graph failed with error Stale file handle"
    irrespective of type of graph it received call back from.
    
    Solution : Introduced a check to find out the graph from which
    the snapview-client received call-back.
    
    Change-Id: Iadd5b525c394be3675d40231711058e1cf1396cd
    BUG: 1146479
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8851
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2014-12-16 08:42:32 UTC
REVIEW: http://review.gluster.org/9281 (USS : Decide the log entry based on the type of graph.) posted (#1) for review on release-3.6 by Raghavendra Bhat (raghavendra)

Comment 2 Anand Avati 2014-12-16 13:38:03 UTC
COMMIT: http://review.gluster.org/9281 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit 6e423ca7903e67214ce35ee9c308b82057530abf
Author: Sachin Pandit <spandit>
Date:   Thu Sep 25 08:32:52 2014 +0530

    USS : Decide the log entry based on the type of graph.
    
    Problem : When a lookup is issued, and if the entry is not found
    then snapview-client will log failure stating that
    "Lookup on normal graph failed with error Stale file handle"
    irrespective of type of graph it received call back from.
    
    Solution : Introduced a check to find out the graph from which
    the snapview-client received call-back.
    
    > Change-Id: Iadd5b525c394be3675d40231711058e1cf1396cd
    > BUG: 1146479
    > Signed-off-by: Sachin Pandit <spandit>
    > Reviewed-on: http://review.gluster.org/8851
    > Reviewed-by: Raghavendra Bhat <raghavendra>
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Vijay Bellur <vbellur>
    > Signed-off-by: Raghavendra Bhat <raghavendra>
    
    Change-Id: I6971d3e2a44db14431205b4c14cffd86a79de51f
    BUG: 1174639
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/9281
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Sachin Pandit <spandit>

Comment 3 Kaushal 2016-02-04 15:05:34 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v3.6.2, please open a new bug report.

glusterfs-v3.6.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978top
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Kaushal 2016-02-04 15:08:06 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v3.6.2, please open a new bug report.

glusterfs-v3.6.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2015/01/glusterfs-3-6-2-ga-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user