Bug 1215907

Summary:	cli should return error with inode quota cmds on cluster with op_version less than 3.7
Product:	[Community] GlusterFS	Reporter:	Vijaikumar Mallikarjuna <vmallika>
Component:	quota	Assignee:	Vijaikumar Mallikarjuna <vmallika>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, gluster-bugs, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1212253	Environment:
Last Closed:	2015-05-14 17:27:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1212253
Bug Blocks:	1186580, 1199352

Description Vijaikumar Mallikarjuna 2015-04-28 06:22:54 UTC

+++ This bug was initially created as a clone of Bug #1212253 +++

In a heterogeneous cluster with op_version less 3.7, quota inodes will account on those bricks which has glusterfs version 3.7 and no this is not available in older version.
This will have incorrect values displayed when user queries inode count from CLI.

So CLI should display error 'Inode quotas supported only with cluster version 3.7 and above'

--- Additional comment from Anand Avati on 2015-04-16 00:33:12 EDT ---

REVIEW: http://review.gluster.org/10261 (quota: display error when setting/removing object limits with ver < 3.7) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-04-16 05:06:35 EDT ---

REVIEW: http://review.gluster.org/10261 (quota: display error when inode-quota cmds executed with cluster ver < 3.7) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-04-16 05:24:33 EDT ---

REVIEW: http://review.gluster.org/10261 (quota: display error when inode-quota cmds executed with cluster ver < 3.7) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-04-16 05:59:05 EDT ---

REVIEW: http://review.gluster.org/10261 (quota: display error when inode-quota cmds executed with cluster ver < 3.7) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-04-17 02:47:54 EDT ---

REVIEW: http://review.gluster.org/10261 (quota: display error when inode-quota cmds executed with cluster ver < 3.7) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-04-28 00:57:51 EDT ---

COMMIT: http://review.gluster.org/10261 committed in master by Vijay Bellur (vbellur) 
------
commit 1adf231fc425ac35eb91a5b771ea0c5c97b1f6c3
Author: vmallika <vmallika>
Date:   Thu Apr 16 08:10:01 2015 +0530

    quota: display error when inode-quota cmds executed with cluster ver < 3.7
    
    In a heterogeneous cluster with op_version less than 3.7, inode quotas will
    be accounted on those bricks which has glusterfs version 3.7 and this is
    not available in older version.
    This will have incorrect values displayed when user queries inode count
    from CLI.
    
    This patch will display error when inode-quota commands
    are executed with cluster version less than 3.7
    
    Change-Id: Ia0e6d5635d1d8e7b2e2cfc3daa7b7f9e314a263a
    BUG: 1212253
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/10261
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2015-04-28 06:25:21 UTC

REVIEW: http://review.gluster.org/10415 (quota: display error when inode-quota cmds executed with cluster ver < 3.7) posted (#1) for review on release-3.7 by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2015-04-28 17:28:41 UTC

COMMIT: http://review.gluster.org/10415 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit a7e04388e03f3706c40be9d9444784a1579ed51d
Author: vmallika <vmallika>
Date:   Tue Apr 28 11:53:24 2015 +0530

    quota: display error when inode-quota cmds executed with cluster ver < 3.7
    
    This is a backport of http://review.gluster.org/#/c/10261/
    
    > In a heterogeneous cluster with op_version less than 3.7, inode quotas will
    > be accounted on those bricks which has glusterfs version 3.7 and this is
    > not available in older version.
    > This will have incorrect values displayed when user queries inode count
    > from CLI.
    >
    > This patch will display error when inode-quota commands
    > are executed with cluster version less than 3.7
    >
    > Change-Id: Ia0e6d5635d1d8e7b2e2cfc3daa7b7f9e314a263a
    > BUG: 1212253
    > Signed-off-by: vmallika <vmallika>
    > Reviewed-on: http://review.gluster.org/10261
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > Reviewed-by: Vijay Bellur <vbellur>
    
    Change-Id: I1ddd605e5b87a248aa85f0eab14c404895751083
    BUG: 1215907
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/10415
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2015-05-14 17:27:27 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:28:49 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:35:20 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user