Bug 1243041

Summary:	SMB: share entry from smb.conf is not removed after setting user.cifs and user.smb to disable.
Product:	[Community] GlusterFS	Reporter:	Raghavendra Talur <rtalur>
Component:	gluster-smb	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED EOL	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.7.2	CC:	asrivast, bugs, nlevinki, rhs-smb, rkavunga, rtalur, sankarshan, sbhaloth, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1242892	Environment:
Last Closed:	2017-03-08 10:50:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1242892
Bug Blocks:	1242767, 1279240

Description Raghavendra Talur 2015-07-14 15:32:52 UTC

+++ This bug was initially created as a clone of Bug #1242892 +++

Description of problem:
********************************************
Setting user.smb and user.cifs to disable doesn't remove the samba share from smb.conf.

How reproducible:
always

Steps to Reproduce:
1.create a volume
2.Start the volume
3.Set the user.cifs and user.smb to disable
4.check the output from testparm or check smb.conf
5.Share entry for the volume should be removed.

Actual results:
share is still present in smb.conf and is ready for access.

Expected results:
share entry should be removed and the share should not be ready for access if user.cifs and user.smb is disabled.

--- Additional comment from Anand Avati on 2015-07-14 18:19:33 IST ---

REVIEW: http://review.gluster.org/11664 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#1) for review on master by Raghavendra Talur (rtalur)

--- Additional comment from Anand Avati on 2015-07-14 18:22:39 IST ---

REVIEW: http://review.gluster.org/11664 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#2) for review on master by Raghavendra Talur (rtalur)

--- Additional comment from Anand Avati on 2015-07-14 18:22:56 IST ---

REVIEW: http://review.gluster.org/11664 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#3) for review on master by Raghavendra Talur (rtalur)

--- Additional comment from Anand Avati on 2015-07-14 21:02:14 IST ---

REVIEW: http://review.gluster.org/11667 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#1) for review on release-3.7 by Raghavendra Talur (rtalur)

Comment 1 Vijay Bellur 2015-10-28 10:04:00 UTC

REVIEW: http://review.gluster.org/11669 (extras/hooks: Fix parsing of args in S30samba-set.sh) posted (#3) for review on release-3.7 by Raghavendra Talur (rtalur)

Comment 2 Vijay Bellur 2015-11-02 11:29:04 UTC

REVIEW: http://review.gluster.org/11669 (extras/hooks: Fix parsing of args in S30samba-set.sh) posted (#4) for review on release-3.7 by Raghavendra Talur (rtalur)

Comment 3 Raghavendra Talur 2015-11-08 20:27:54 UTC

This bug could not be fixed in time for glusterfs-3.7.6.
This is now being tracked for being fixed in glusterfs-3.7.7.

Comment 4 Vijay Bellur 2015-11-15 11:15:29 UTC

COMMIT: http://review.gluster.org/11669 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 89db0268a75f7e7d01e5660e4cc3ffdd8487acd1
Author: Raghavendra Talur <rtalur>
Date:   Tue Jul 14 23:24:55 2015 +0530

    extras/hooks: Fix parsing of args in S30samba-set.sh
    
    bug: 1243041
    Change-Id: I75756f44757a144b0ed229fcc0e29a273fc75886
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/11669
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 5 Kaushal 2017-03-08 10:50:48 UTC

This bug is getting closed because GlusteFS-3.7 has reached its end-of-life.

Note: This bug is being closed using a script. No verification has been performed to check if it still exists on newer releases of GlusterFS.
If this bug still exists in newer GlusterFS releases, please reopen this bug against the newer release.