Bug 1324809
Summary: | arbiter volume write performance is bad. | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Ravishankar N <ravishankar> |
Component: | arbiter | Assignee: | Ravishankar N <ravishankar> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.7.10 | CC: | bugs |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.7.11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 1324004 | Environment: | |
Last Closed: | 2016-04-19 07:13:37 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1324004 | ||
Bug Blocks: |
Description
Ravishankar N
2016-04-07 10:49:03 UTC
REVIEW: http://review.gluster.org/13925 (arbiter: write performance improvement) posted (#1) for review on release-3.7 by Ravishankar N (ravishankar) REVIEW: http://review.gluster.org/13925 (arbiter: write performance improvement) posted (#2) for review on release-3.7 by Ravishankar N (ravishankar) COMMIT: http://review.gluster.org/13925 committed in release-3.7 by Kaushal M (kaushal) ------ commit c9c2c08d34003f49bc3a509757a135665fb20518 Author: Ravishankar N <ravishankar> Date: Tue Apr 5 15:16:52 2016 +0530 arbiter: write performance improvement Backport of: http://review.gluster.org/#/c/13906 Problem: The throughput for a 'dd' workload was much less for arbiter configuration when compared to normal replica-3 volume. There were 2 issues: i)arbiter_writev was using the request dict as response dict while unwinding, leading to incorect GLUSTERFS_WRITE_IS_APPEND and GLUSTERFS_OPEN_FD_COUNT values (=4), leading to immediate post-ops because is_afr_delayed_changelog_post_op_needed() failed due to afr_are_multiple_fds_opened() check. ii) The arbiter code in afr was setting local->transaction.{start and len} =0 to take full file locks. What this meant was even for simultaenous but non-overlapping writevs, afr_transaction_eager_lock_init() was not happening because afr_locals_overlap() always stays true. Consequently is_afr_delayed_changelog_post_op_needed() failed due to local->delayed_post_op not being set. Fix: i) Send appropriate response dict values in arbiter_writev. ii) Modify flock params instead of local->transaction.{start and len} to take full file locks in the transaction. Also changed _fill_writev_xdata() in posix to fill rsp_xdata for whatever key is requested for. Change-Id: I1c5fc5e98aba49ade540bb441a022e65b753432a BUG: 1324809 Signed-off-by: Ravishankar N <ravishankar> Reported-by: Robert Rauch <robert.rauch> Reported-by: Russel Purinton <russell.purinton> Reviewed-on: http://review.gluster.org/13925 Smoke: Gluster Build System <jenkins.com> Reviewed-by: Pranith Kumar Karampuri <pkarampu> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.11, please open a new bug report. glusterfs-3.7.11 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-April/026321.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |