Bug 1038391 - gf-error-codes.h is missing from source tarball
Summary: gf-error-codes.h is missing from source tarball
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1089054
TreeView+ depends on / blocked
 
Reported: 2013-12-05 03:37 UTC by Louis Zuckerman
Modified: 2014-11-11 08:25 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1089054 (view as bug list)
Environment:
Last Closed: 2014-11-11 08:25:16 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Louis Zuckerman 2013-12-05 03:37:11 UTC
Description of problem:

Source tarballs for 3.5qa1 & 3.5qa2 are missing gf-error-codes.h.  It is necessary to run autogen.sh to generate the file before running configure.

Version-Release number of selected component (if applicable):

3.5qa1 & 3.5qa2

How reproducible:

Consistently

Steps to Reproduce:
1. Download source tarball (http://bits.gluster.org/pub/gluster/glusterfs/src/glusterfs-3.5qa2.tar.gz)
2. Run configure
3. Run make

Actual results:
very early in the build process, the following error halts progress...

logging.c:29:28: fatal error: gf-error-codes.h: No such file or directory


Expected results:

glusterfs builds completely

Additional info:

I'm not certain if this is a bug or not.  In all previous release tarballs of glusterfs it was not necessary to run autogen.sh before configure.  Now with the 3.5qa releases it is necessary to run autogen.sh to generate gf-error-codes.h

Thank you.

Comment 1 Bala.FA 2013-12-10 05:42:29 UTC
Lous, This http://review.gluster.org/#/c/5382/ may be interesting fix.

./autogen.sh is necessary when updating error codes and maintainer does before releasing tarball, I think we could include gf-error-codes.h file in the tarball.

Comment 2 Niels de Vos 2014-04-17 18:57:35 UTC
This bug is for getting the change included in the master branch,when that is done, please submit a change for the release-3.5 branch against Bug 1089054.

Thanks!

Comment 3 Harshavardhana 2014-04-17 19:08:50 UTC
During rpmbuild 'autogen.sh' is used explicitly for the same reason, i know it shouldn't be necessary. 

It would be ideal to gf-errorcodes.h.template to be like - gf-errorcodes.h.in and let the gen-headers.py run on it through configure itself. 

AC_CONFIG_FILES (file..., [cmds], [init-cmds]) --> by running gen-headers.py with in this

Comment 4 Anand Avati 2014-05-08 15:37:40 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 5 Anand Avati 2014-05-17 10:17:35 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 6 Anand Avati 2014-05-17 19:18:49 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#3) for review on master by Niels de Vos (ndevos)

Comment 7 Anand Avati 2014-05-18 09:30:48 UTC
REVIEW: http://review.gluster.org/7786 (tests/rpm: always run ./autogen.sh to create missing files) posted (#3) for review on master by Niels de Vos (ndevos)

Comment 8 Anand Avati 2014-05-18 10:06:59 UTC
REVIEW: http://review.gluster.org/7786 (tests/rpm: always run ./autogen.sh to create missing files) posted (#4) for review on master by Niels de Vos (ndevos)

Comment 9 Anand Avati 2014-05-18 10:07:09 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#4) for review on master by Niels de Vos (ndevos)

Comment 10 Anand Avati 2014-05-19 07:32:43 UTC
REVIEW: http://review.gluster.org/7786 (tests/rpm: always run ./autogen.sh to create missing files) posted (#5) for review on master by Niels de Vos (ndevos)

Comment 11 Anand Avati 2014-05-19 07:32:50 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#5) for review on master by Niels de Vos (ndevos)

Comment 12 Anand Avati 2014-05-19 09:41:12 UTC
REVIEW: http://review.gluster.org/7786 (tests/rpm: always run ./autogen.sh to create missing files) posted (#6) for review on master by Niels de Vos (ndevos)

Comment 13 Anand Avati 2014-05-19 09:41:18 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#6) for review on master by Niels de Vos (ndevos)

Comment 14 Anand Avati 2014-05-19 14:00:38 UTC
REVIEW: http://review.gluster.org/7786 (tests/rpm: always run ./autogen.sh to create missing files) posted (#7) for review on master by Niels de Vos (ndevos)

Comment 15 Anand Avati 2014-05-19 14:00:45 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#7) for review on master by Niels de Vos (ndevos)

Comment 16 Anand Avati 2014-05-20 08:12:10 UTC
REVIEW: http://review.gluster.org/7786 (tests/rpm: always run ./autogen.sh to create missing files) posted (#8) for review on master by Niels de Vos (ndevos)

Comment 17 Anand Avati 2014-05-20 08:12:16 UTC
REVIEW: http://review.gluster.org/7714 (logging: remove unused message-id scripts) posted (#8) for review on master by Niels de Vos (ndevos)

Comment 18 Anand Avati 2014-05-22 05:21:55 UTC
COMMIT: http://review.gluster.org/7786 committed in master by Anand Avati (avati) 
------
commit 79de5b63775f1ab8e2e498fd51b55509a30cd896
Author: Niels de Vos <ndevos>
Date:   Mon May 19 09:25:34 2014 +0200

    tests/rpm: always run ./autogen.sh to create missing files
    
    In some occasions 'install-sh' seems to be missing in the 'make dist'
    tarball when ./autogen.sh has not been run (skipped when 'configure'
    exists). With this changes, 'autogen.sh' is always run so that missing
    files should get added to the tarball.
    
    Also write the logs from mock to a known location, and copy them to the
    '/var/log/' directory that Jenkins archives after a regression test
    failure. This makes it easier to find build issues that mock detects.
    
    Change-Id: I8d0cf1afef61ebab0137aa0d20521e75a35ddbdd
    BUG: 1038391
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/7786
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Anand Avati <avati>

Comment 19 Anand Avati 2014-05-22 09:49:05 UTC
COMMIT: http://review.gluster.org/7714 committed in master by Vijay Bellur (vbellur) 
------
commit cec37c9b66b8711b213f114875d215f56b8120aa
Author: Niels de Vos <ndevos>
Date:   Thu May 8 12:30:23 2014 -0300

    logging: remove unused message-id scripts
    
    The current unused implementation for message-ids in the logs depends on
    automatically generated files. The generated files are not included in
    the distributed tarball. This causes issues when distributions build
    packages, they need to re-run ./autogen.sh to create the needed files.
    
    I thought of including the generated files in the distribution tarball.
    However, the contents of these files are not actively used, so it seems
    to make more sense to drop it all together. These functions were the
    only users of libintl and gettext too, so dropped the requirement
    checking from configure.ac.
    
    A replacement for the message-id logging framework is in progress. Any
    changes that this patch makes, can be reverted in the submission of
    patches for the new framework.
    
    Reference: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6212
    Change-Id: Iea82dd3910944a5c6be3ee393806eccabd575e11
    BUG: 1038391
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/7714
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 20 Niels de Vos 2014-09-22 12:33:19 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 21 Niels de Vos 2014-11-11 08:25:16 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.