Bug 1060703 - client_t calls __sync_sub_and_fetch and causes link failures on EPEL-5-i386
Summary: client_t calls __sync_sub_and_fetch and causes link failures on EPEL-5-i386
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-03 12:18 UTC by Niels de Vos
Modified: 2014-04-17 11:52 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.5.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-17 11:52:56 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
build.log (255.90 KB, text/plain)
2014-02-03 12:18 UTC, Niels de Vos
no flags Details

Description Niels de Vos 2014-02-03 12:18:46 UTC
Created attachment 858537 [details]
build.log

Description of problem:
Automatic nightly building for EPEL-5-i386 fails like this:

../../libglusterfs/src/.libs/libglusterfs.so: undefined reference to `__sync_sub_and_fetch_4'
collect2: ld returned 1 exit status
make[3]: *** [glusterfsd] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.52399 (%build)
    Bad exit status from /var/tmp/rpm-tmp.52399 (%build)


Version-Release number of selected component (if applicable):
todays release-3.5 branch

How reproducible:
100%

Steps to Reproduce:
1. rebuild the srpm in with 'mock -r epel-5-i386 ...src.rpm'

Actual results:
Rebuild fails.

Expected results:
Rebuild succeeds.

Additional info:
It seems others have had this issue too:
- http://trac.wxwidgets.org/ticket/4542
- http://trac.wxwidgets.org/changeset/74934

My understanding is that we can not assume that atomic built-ins are available, and may need to link to libatomic or something else for those.

Comment 1 Anand Avati 2014-02-03 16:00:58 UTC
REVIEW: http://review.gluster.org/6894 (libglusterfs/client_t.c: rhel5/i386 atomic link failure) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Anand Avati 2014-02-03 16:05:11 UTC
REVIEW: http://review.gluster.org/6895 (libglusterfs/client_t.c: rhel5/i386 atomic link failure) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Anand Avati 2014-02-03 16:13:23 UTC
REVIEW: http://review.gluster.org/6896 (libglusterfs/client_t.c: rhel5/i386 atomic link failure) posted (#1) for review on release-3.5 by Kaleb KEITHLEY (kkeithle)

Comment 4 Anand Avati 2014-02-05 17:24:13 UTC
REVIEW: http://review.gluster.org/6894 (libglusterfs/client_t.c: rhel5/i386 atomic link failure) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 5 Anand Avati 2014-02-05 18:36:05 UTC
REVIEW: http://review.gluster.org/6896 (libglusterfs/client_t.c: rhel5/i386 atomic link failure) posted (#2) for review on release-3.5 by Kaleb KEITHLEY (kkeithle)

Comment 6 Anand Avati 2014-02-05 19:46:05 UTC
REVIEW: http://review.gluster.org/6894 (libglusterfs/client_t.c: rhel5/i386 atomic link failure) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 7 Anand Avati 2014-02-05 19:51:21 UTC
REVIEW: http://review.gluster.org/6896 (libglusterfs/client_t.c: rhel5/i386 atomic link failure) posted (#3) for review on release-3.5 by Kaleb KEITHLEY (kkeithle)

Comment 8 Anand Avati 2014-02-07 17:29:25 UTC
REVIEW: http://review.gluster.org/6894 (libglusterfs/client_t.c: rhel5/i386 atomic, link failure) posted (#4) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 9 Anand Avati 2014-02-07 17:40:11 UTC
REVIEW: http://review.gluster.org/6896 (libglusterfs/client_t.c: rhel5/i386 atomic, link failure) posted (#4) for review on release-3.5 by Kaleb KEITHLEY (kkeithle)

Comment 10 Anand Avati 2014-02-10 13:37:20 UTC
REVIEW: http://review.gluster.org/6894 (libglusterfs/client_t.c: rhel5/i386 atomic, link failure) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 11 Anand Avati 2014-02-11 08:24:28 UTC
COMMIT: http://review.gluster.org/6894 committed in master by Vijay Bellur (vbellur) 
------
commit 7ee0275333469f82e59214802601dc6e3c45f6d1
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Mon Feb 3 10:58:47 2014 -0500

    libglusterfs/client_t.c: rhel5/i386 atomic, link failure
    
    RHEL5's gcc-4.1.2 on i386 does not have built-in atomic __sync_*()
    
    Change-Id: If7b1027570a6c8c962392871b002be0a37258ed3
    BUG: 1060703
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/6894
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 12 Anand Avati 2014-02-11 08:24:49 UTC
COMMIT: http://review.gluster.org/6896 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit b319f01ecd8568659f365f4fa6bbed0acf06db76
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Mon Feb 3 11:10:01 2014 -0500

    libglusterfs/client_t.c: rhel5/i386 atomic, link failure
    
    RHEL5's gcc-4.1.2 on i386 does not have built-in atomic __sync_*()
    
    Change-Id: I50e3d1e0883afee3fbba44e172fee4b933b28e49
    BUG: 1060703
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/6896
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 14 Niels de Vos 2014-04-17 11:52:56 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.