Bug 1104714 - [SNAPSHOT]: before the snap is marked to be deleted if the node goes down than the snaps are propagated on other nodes and glusterd hungs
Summary: [SNAPSHOT]: before the snap is marked to be deleted if the node goes down tha...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: pre-release
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Avra Sengupta
QA Contact:
URL:
Whiteboard: SNAPSHOT
Depends On: 1101463 1104635
Blocks: 1175754
TreeView+ depends on / blocked
 
Reported: 2014-06-04 14:28 UTC by Avra Sengupta
Modified: 2016-05-02 20:47 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.6.1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1104635
: 1175754 (view as bug list)
Environment:
Last Closed: 2014-11-10 15:13:40 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2014-06-05 16:12:05 UTC
REVIEW: http://review.gluster.org/7996 (glusterd/snapshot: Fix snap delete cleanup) posted (#1) for review on master by Avra Sengupta (asengupt)

Comment 2 Anand Avati 2014-06-11 10:48:46 UTC
REVIEW: http://review.gluster.org/7996 (glusterd/snapshot: Fix snap delete cleanup) posted (#2) for review on master by Avra Sengupta (asengupt)

Comment 3 Anand Avati 2014-06-11 11:14:11 UTC
REVIEW: http://review.gluster.org/7996 (glusterd/snapshot: Fix snap delete cleanup) posted (#3) for review on master by Avra Sengupta (asengupt)

Comment 4 Anand Avati 2014-06-12 09:28:56 UTC
REVIEW: http://review.gluster.org/7996 (glusterd/snapshot: Fix snap delete cleanup) posted (#4) for review on master by Avra Sengupta (asengupt)

Comment 5 Anand Avati 2014-06-12 10:38:58 UTC
REVIEW: http://review.gluster.org/7996 (glusterd/snapshot: Fix snap delete cleanup) posted (#5) for review on master by Avra Sengupta (asengupt)

Comment 6 Anand Avati 2014-06-13 11:41:16 UTC
COMMIT: http://review.gluster.org/7996 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 5b0f65717f0d9489ca1c8750724cf9c8bfa11cbc
Author: Avra Sengupta <asengupt>
Date:   Fri Jun 6 12:48:32 2014 +0000

    glusterd/snapshot: Fix snap delete cleanup
    
    During commit the first thing that should happen is the
    snaps should be marked as GD_SNAP_STATUS_DECOMMISSION.
    So that if the node goes down the marked snap can be
    cleaned up when the node is coming back. Also during snap
    handshake while accepting snapshot from peer, we should
    check if the snap in question is decomissioned. In that
    case we shouldn't be accepting the peer data.
    
    Change-Id: Ib4e38d1b6bf49411928623fbc9f72f2b37b72086
    BUG: 1104714
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/7996
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 7 Niels de Vos 2014-09-22 12:42:01 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 8 Avra Sengupta 2014-10-20 08:20:00 UTC
glusterd is not hung, but unable to delete stale snapshots

Comment 9 Anand Avati 2014-10-21 09:06:15 UTC
REVIEW: http://review.gluster.org/8954 (glusterd/snapshot: Check if LVM device path exists before delete.) posted (#1) for review on master by Avra Sengupta (asengupt)

Comment 10 Anand Avati 2014-10-21 10:46:18 UTC
REVIEW: http://review.gluster.org/8954 (glusterd/snapshot: Check if LVM device path exists before delete.) posted (#2) for review on master by Avra Sengupta (asengupt)

Comment 11 Niels de Vos 2014-11-10 15:13:40 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users

Comment 12 Anand Avati 2014-11-12 09:03:57 UTC
REVIEW: http://review.gluster.org/8954 (glusterd/snapshot: Check if LVM device path exists before delete.) posted (#3) for review on master by Avra Sengupta (asengupt)

Comment 13 Anand Avati 2014-11-12 11:30:40 UTC
COMMIT: http://review.gluster.org/8954 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 55aa4b185561edd7b3d1ab77a4f29a4facfdd7ff
Author: Avra Sengupta <asengupt>
Date:   Tue Oct 21 08:42:40 2014 +0000

    glusterd/snapshot: Check if LVM device path exists before delete.
    
    Check if the LV is present before deleting the LV. In case where
    the LV is absent (already deleted?), need not fail the snap delete
    operation.
    
    Also check if the LV is mounted before trying umount. In case it
    isn't umounted, only remove the LV.
    
    Change-Id: I0f5b2674797299d8748c6fac5b091f0caba65ca4
    BUG: 1104714
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/8954
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>


Note You need to log in before you can comment on or make changes to this bug.