Bug 1170254 - Fix mutex problems reported by coverity scan
Summary: Fix mutex problems reported by coverity scan
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: disperse
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Xavi Hernandez
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1170954
TreeView+ depends on / blocked
 
Reported: 2014-12-03 15:32 UTC by Xavi Hernandez
Modified: 2015-05-14 17:45 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1170954 (view as bug list)
Environment:
Last Closed: 2015-05-14 17:28:38 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Xavi Hernandez 2014-12-03 15:32:07 UTC 
Description of problem:

Coverity scan reported 3 issues related to mutexes:

    CID1241484 Data race condition
    CID1241486 Data race condition
    CID1256173 Thread deadlock

Version-Release number of selected component (if applicable): master


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Anand Avati 2014-12-03 15:45:40 UTC 
REVIEW: http://review.gluster.org/9230 (ec: Fix mutex related coverity scan issues) posted (#1) for review on master by Xavier Hernandez (xhernandez)
Comment 2 Anand Avati 2014-12-04 19:36:36 UTC 
COMMIT: http://review.gluster.org/9230 committed in master by Vijay Bellur (vbellur) 
------
commit 30ae004100067f52fe156098ffb215417db5559e
Author: Xavier Hernandez <xhernandez>
Date:   Wed Dec 3 16:42:31 2014 +0100

    ec: Fix mutex related coverity scan issues
    
    This patch solves 3 issues detected by coverity scan:
    
        CID1241484 Data race condition
        CID1241486 Data race condition
        CID1256173 Thread deadlock
    
    With this patch, inode lock is never acquired inside a region locked
    with fop->lock.
    
    Change-Id: I35c4633efd1b68b9f72b42661fa7c728b1f52c6a
    BUG: 1170254
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9230
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
Comment 3 Anand Avati 2014-12-10 12:33:05 UTC 
REVIEW: http://review.gluster.org/9263 (ec: Fix more mutex related coverity scan issues) posted (#1) for review on master by Xavier Hernandez (xhernandez)
Comment 4 Anand Avati 2014-12-17 17:14:55 UTC 
COMMIT: http://review.gluster.org/9263 committed in master by Vijay Bellur (vbellur) 
------
commit 531e0a70ff7a7b87baf0a8886d1de880293c3fcb
Author: Xavier Hernandez <xhernandez>
Date:   Wed Dec 10 13:28:17 2014 +0100

    ec: Fix more mutex related coverity scan issues
    
    This patch solves CID 1257622.
    
    Change-Id: I95680c7de49cd84011d2ad38f02e5fad82e15c90
    BUG: 1170254
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9263
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
Comment 5 Niels de Vos 2015-05-14 17:28:38 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Comment 6 Niels de Vos 2015-05-14 17:35:45 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Comment 7 Niels de Vos 2015-05-14 17:38:07 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Comment 8 Niels de Vos 2015-05-14 17:45:13 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Note You need to log in before you can comment on or make changes to this bug.